runtime/bin/vmservice/observatory/lib/src/elements/inbound_reference.dart - Issue 509563004: Give instances their own model class; move DartErrors out of instance-ref into their own error-ref.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice/observatory/lib/src/elements/inbound_reference.dart

Issue 509563004: Give instances their own model class; move DartErrors out of instance-ref into their own error-ref. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: rebase and build Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/bin/vmservice/observatory/lib/src/elements/field_view.html ('k') | runtime/bin/vmservice/observatory/lib/src/elements/instance_ref.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/bin/vmservice/observatory/lib/src/elements/inbound_reference.dart

diff --git a/runtime/bin/vmservice/observatory/lib/src/elements/inbound_reference.dart b/runtime/bin/vmservice/observatory/lib/src/elements/inbound_reference.dart

index 9efa1bf63cc5bf325259f8fa291c73aa12fd63a5..436c7b551b842fc904da1041174253c4149febe9 100644

--- a/runtime/bin/vmservice/observatory/lib/src/elements/inbound_reference.dart

+++ b/runtime/bin/vmservice/observatory/lib/src/elements/inbound_reference.dart

@@ -11,6 +11,7 @@ import 'service_ref.dart';

@CustomTag('inbound-reference')

class InboundReferenceElement extends ServiceRefElement {

+ @published ObservableMap ref;

InboundReferenceElement.created() : super.created();

dynamic get slot => (ref as ServiceMap)['slot'];

@@ -40,9 +41,7 @@ class InboundReferenceElement extends ServiceRefElement {

notifyPropertyChange(#ref, 0, 1);

}).whenComplete(done);

} else {

- ServiceMap refMap = ref;

- refMap['fields'] = null;

- refMap['elements'] = null;

+ inboundReferences = null;

done();

}