Issue 499723002: Implement 'edit.getRefactoring' for rename refactoring.

Issue 499723002: Implement 'edit.getRefactoring' for rename refactoring. (Closed)

Created:
6 years, 4 months ago by scheglov

Modified:
6 years, 4 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Implement 'edit.getRefactoring' for rename refactoring. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=39509

Patch Set 2 : Tweak for comment #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+593 lines, -59 lines)			Patch
M	pkg/analysis_server/lib/src/edit/edit_domain.dart	View	1	4 chunks	+168 lines, -4 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/refactoring/naming_conventions.dart	View		5 chunks	+6 lines, -6 lines	0 comments	Download
M	pkg/analysis_server/test/edit/refactoring_test.dart	View		3 chunks	+368 lines, -1 line	0 comments	Download
M	pkg/analysis_server/test/mocks.dart	View		2 chunks	+4 lines, -1 line	0 comments	Download
M	pkg/analysis_server/test/services/refactoring/extract_local_test.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/analysis_server/test/services/refactoring/naming_conventions_test.dart	View		20 chunks	+22 lines, -22 lines	0 comments	Download
M	pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	pkg/analysis_server/test/services/refactoring/rename_constructor_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_server/test/services/refactoring/rename_import_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_server/test/services/refactoring/rename_library_test.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/analysis_server/test/services/refactoring/rename_local_test.dart	View		4 chunks	+6 lines, -6 lines	0 comments	Download
M	pkg/analysis_server/test/services/refactoring/rename_unit_member_test.dart	View		5 chunks	+9 lines, -9 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/499723002/diff/1/pkg/analysis_server/lib/src/edit/edit_domain.dart File pkg/analysis_server/lib/src/edit/edit_domain.dart (right): https://codereview.chromium.org/499723002/diff/1/pkg/analysis_server/lib/src/edit/edit_domain.dart#newcode163 pkg/analysis_server/lib/src/edit/edit_domain.dart:163: * An object managing [Refactoring] instances. I think ...

6 years, 4 months ago (2014-08-23 17:53:16 UTC) #2

scheglov

https://codereview.chromium.org/499723002/diff/1/pkg/analysis_server/lib/src/edit/edit_domain.dart File pkg/analysis_server/lib/src/edit/edit_domain.dart (right): https://codereview.chromium.org/499723002/diff/1/pkg/analysis_server/lib/src/edit/edit_domain.dart#newcode163 pkg/analysis_server/lib/src/edit/edit_domain.dart:163: * An object managing [Refactoring] instances. On 2014/08/23 17:53:16, ...

6 years, 4 months ago (2014-08-23 21:14:07 UTC) #3

scheglov

6 years, 4 months ago (2014-08-23 21:14:39 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as 39509 (presubmit successful).

Expand Messages | Collapse Messages