pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart - Issue 499723002: Implement 'edit.getRefactoring' for rename refactoring.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart

Issue 499723002: Implement 'edit.getRefactoring' for rename refactoring. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Tweak for comment Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/test/services/refactoring/naming_conventions_test.dart ('k') | pkg/analysis_server/test/services/refactoring/rename_constructor_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart

diff --git a/pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart b/pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart

index 1d6b4b9ebe011bf925abe6667d7a542f731a08d8..0372d8a63a8f4d6ee44e7c3e2bad751cf1c267ed 100644

--- a/pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart

+++ b/pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart

@@ -264,7 +264,7 @@ class A {

refactoring.newName = null;

assertRefactoringStatus(

refactoring.checkNewName(),

- RefactoringProblemSeverity.ERROR,

+ RefactoringProblemSeverity.FATAL,

expectedMessage: "Field name must not be null.");

// OK

refactoring.newName = 'newName';

@@ -282,7 +282,7 @@ class A {

refactoring.newName = null;

assertRefactoringStatus(

refactoring.checkNewName(),

- RefactoringProblemSeverity.ERROR,

+ RefactoringProblemSeverity.FATAL,

expectedMessage: "Constant name must not be null.");

// not upper case

refactoring.newName = 'newName';

@@ -305,13 +305,13 @@ class A {

refactoring.newName = null;

assertRefactoringStatus(

refactoring.checkNewName(),

- RefactoringProblemSeverity.ERROR,

+ RefactoringProblemSeverity.FATAL,

expectedMessage: "Method name must not be null.");

// empty

refactoring.newName = '';

assertRefactoringStatus(

refactoring.checkNewName(),

- RefactoringProblemSeverity.ERROR,

+ RefactoringProblemSeverity.FATAL,

expectedMessage: "Method name must not be empty.");

// same

refactoring.newName = 'test';