Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1282)

Unified Diff: pkg/analysis_server/test/services/refactoring/rename_unit_member_test.dart

Issue 499723002: Implement 'edit.getRefactoring' for rename refactoring. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Tweak for comment Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/test/services/refactoring/rename_local_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/services/refactoring/rename_unit_member_test.dart
diff --git a/pkg/analysis_server/test/services/refactoring/rename_unit_member_test.dart b/pkg/analysis_server/test/services/refactoring/rename_unit_member_test.dart
index 276ef5dd05f8a8ae48e6ace01e97bc808a4ee4d3..cf2b660a57255862a20353c075a9f6167360cea8 100644
--- a/pkg/analysis_server/test/services/refactoring/rename_unit_member_test.dart
+++ b/pkg/analysis_server/test/services/refactoring/rename_unit_member_test.dart
@@ -224,13 +224,13 @@ class Test {}
refactoring.newName = null;
assertRefactoringStatus(
refactoring.checkNewName(),
- RefactoringProblemSeverity.ERROR,
+ RefactoringProblemSeverity.FATAL,
expectedMessage: "Class name must not be null.");
// empty
refactoring.newName = '';
assertRefactoringStatus(
refactoring.checkNewName(),
- RefactoringProblemSeverity.ERROR,
+ RefactoringProblemSeverity.FATAL,
expectedMessage: "Class name must not be empty.");
// same
refactoring.newName = 'Test';
@@ -252,13 +252,13 @@ test() {}
refactoring.newName = null;
assertRefactoringStatus(
refactoring.checkNewName(),
- RefactoringProblemSeverity.ERROR,
+ RefactoringProblemSeverity.FATAL,
expectedMessage: "Function name must not be null.");
// empty
refactoring.newName = '';
assertRefactoringStatus(
refactoring.checkNewName(),
- RefactoringProblemSeverity.ERROR,
+ RefactoringProblemSeverity.FATAL,
expectedMessage: "Function name must not be empty.");
// OK
refactoring.newName = 'newName';
@@ -274,7 +274,7 @@ typedef Test();
refactoring.newName = null;
assertRefactoringStatus(
refactoring.checkNewName(),
- RefactoringProblemSeverity.ERROR,
+ RefactoringProblemSeverity.FATAL,
expectedMessage: "Function type alias name must not be null.");
// OK
refactoring.newName = 'NewName';
@@ -290,13 +290,13 @@ var test;
refactoring.newName = null;
assertRefactoringStatus(
refactoring.checkNewName(),
- RefactoringProblemSeverity.ERROR,
+ RefactoringProblemSeverity.FATAL,
expectedMessage: "Variable name must not be null.");
// empty
refactoring.newName = '';
assertRefactoringStatus(
refactoring.checkNewName(),
- RefactoringProblemSeverity.ERROR,
+ RefactoringProblemSeverity.FATAL,
expectedMessage: "Variable name must not be empty.");
// OK
refactoring.newName = 'newName';
@@ -312,13 +312,13 @@ const TEST = 0;
refactoring.newName = null;
assertRefactoringStatus(
refactoring.checkNewName(),
- RefactoringProblemSeverity.ERROR,
+ RefactoringProblemSeverity.FATAL,
expectedMessage: "Constant name must not be null.");
// empty
refactoring.newName = '';
assertRefactoringStatus(
refactoring.checkNewName(),
- RefactoringProblemSeverity.ERROR,
+ RefactoringProblemSeverity.FATAL,
expectedMessage: "Constant name must not be empty.");
// OK
refactoring.newName = 'NEW_NAME';
« no previous file with comments | « pkg/analysis_server/test/services/refactoring/rename_local_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698