Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 499073003: Use Uint8List for byte lists in dart:convert. (Closed)

Created:
6 years, 3 months ago by Lasse Reichstein Nielsen
Modified:
6 years, 3 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Use Uint8List for byte lists in dart:convert. BUG= http://dartbug.com/11971 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=39580

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -21 lines) Patch
M runtime/lib/convert_patch.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M sdk/lib/_internal/lib/convert_patch.dart View 1 chunk +0 lines, -7 lines 0 comments Download
M sdk/lib/convert/ascii.dart View 1 chunk +1 line, -2 lines 0 comments Download
M sdk/lib/convert/byte_conversion.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M sdk/lib/convert/utf.dart View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lasse Reichstein Nielsen
lrn@google.com changed reviewers: + sgjesse@google.com
6 years, 3 months ago (2014-08-26 11:56:25 UTC) #1
Lasse Reichstein Nielsen
6 years, 3 months ago (2014-08-26 11:56:25 UTC) #2
Søren Gjesse
lgtm
6 years, 3 months ago (2014-08-26 12:00:05 UTC) #3
Lasse Reichstein Nielsen
6 years, 3 months ago (2014-08-27 08:24:58 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as 39580 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698