sdk/lib/convert/ascii.dart - Issue 499073003: Use Uint8List for byte lists in dart:convert.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/convert/ascii.dart

Issue 499073003: Use Uint8List for byte lists in dart:convert. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/convert/ascii.dart

diff --git a/sdk/lib/convert/ascii.dart b/sdk/lib/convert/ascii.dart

index dd3c39c7687d9c5895eea99eb897bd1a6a5af0b6..281233a57155200ffa1ed854f323772d63ac6190 100644

--- a/sdk/lib/convert/ascii.dart

+++ b/sdk/lib/convert/ascii.dart

@@ -75,8 +75,7 @@ class _UnicodeSubsetEncoder extends Converter<String, List<int>> {

const _UnicodeSubsetEncoder(this._subsetMask);

List<int> convert(String string) {

- // TODO(11971): Use Uint8List when possible.

- List result = new List<int>(string.length);

+ List result = new Uint8List(string.length);

for (int i = 0; i < string.length; i++) {

var codeUnit = string.codeUnitAt(i);

if ((codeUnit & ~_subsetMask) != 0) {

« no previous file with comments | « sdk/lib/_internal/lib/convert_patch.dart ('k') | sdk/lib/convert/byte_conversion.dart » ('j') | no next file with comments »