Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Unified Diff: sdk/lib/convert/utf.dart

Issue 499073003: Use Uint8List for byte lists in dart:convert. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/convert/byte_conversion.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/convert/utf.dart
diff --git a/sdk/lib/convert/utf.dart b/sdk/lib/convert/utf.dart
index 9c416261b6accc52346485b15814a86d17152a0a..332598759af6b4276d9e36506699df1f656df2ae 100644
--- a/sdk/lib/convert/utf.dart
+++ b/sdk/lib/convert/utf.dart
@@ -134,11 +134,10 @@ class _Utf8Encoder {
_Utf8Encoder.withBufferSize(int bufferSize)
: _buffer = _createBuffer(bufferSize);
- // TODO(11971): Always use Uint8List.
/**
* Allow an implementation to pick the most efficient way of storing bytes.
*/
- external static List<int> _createBuffer(int size);
+ static List<int> _createBuffer(int size) => new Uint8List(size);
/**
* Tries to combine the given [leadingSurrogate] with the [nextCodeUnit] and
« no previous file with comments | « sdk/lib/convert/byte_conversion.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698