Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 487023003: vmservice protocol cleanup (Closed)

Created:
6 years, 4 months ago by turnidge
Modified:
6 years, 4 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, Cutch, vm-dev_dartlang.org
Visibility:
Public.

Description

vmservice protocol cleanup user_name -> name name -> vmName Also, vmName is now only provided when it differs from name. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=39525

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : code review #

Patch Set 4 : gen js #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1363 lines, -1379 lines) Patch
M runtime/bin/vmservice/observatory/deployed/web/index.html_bootstrap.dart.js View 1 2 3 245 chunks +620 lines, -615 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/index_devtools.html_bootstrap.dart.js View 1 2 3 245 chunks +620 lines, -615 lines 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/service/object.dart View 5 chunks +11 lines, -10 lines 0 comments Download
M runtime/vm/coverage_test.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/debugger_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/object.cc View 1 2 14 chunks +39 lines, -49 lines 0 comments Download
M runtime/vm/pages.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/vm/profiler.cc View 8 chunks +0 lines, -8 lines 0 comments Download
M runtime/vm/report_test.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M runtime/vm/scavenger.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/vm/service/protocol.md View 1 4 chunks +6 lines, -6 lines 0 comments Download
M runtime/vm/service_test.cc View 27 chunks +36 lines, -36 lines 0 comments Download
M tests/standalone/vmservice/isolate_class_field_test.dart View 5 chunks +7 lines, -15 lines 0 comments Download
M tests/standalone/vmservice/isolate_code_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/vmservice/isolate_function_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/vmservice/test_helper.dart View 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
turnidge
turnidge@google.com changed reviewers: + johnmccutchan@google.com
6 years, 4 months ago (2014-08-25 17:50:39 UTC) #1
turnidge
6 years, 4 months ago (2014-08-25 17:50:39 UTC) #2
Cutch
lgtm with one small suggestion https://codereview.chromium.org/487023003/diff/20001/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/487023003/diff/20001/runtime/vm/object.cc#newcode4443 runtime/vm/object.cc:4443: jsobj.AddProperty("vmName", vm_name.ToCString()); Maybe: jsobj.AddName(user_name, ...
6 years, 4 months ago (2014-08-25 17:54:52 UTC) #3
turnidge
https://codereview.chromium.org/487023003/diff/20001/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/487023003/diff/20001/runtime/vm/object.cc#newcode4443 runtime/vm/object.cc:4443: jsobj.AddProperty("vmName", vm_name.ToCString()); On 2014/08/25 17:54:52, Cutch wrote: > Maybe: ...
6 years, 4 months ago (2014-08-25 18:20:09 UTC) #4
turnidge
6 years, 4 months ago (2014-08-25 18:53:53 UTC) #5
Message was sent while issue was closed. 
Committed patchset #4 manually as 39525 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698