Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Unified Diff: tests/standalone/vmservice/test_helper.dart

Issue 487023003: vmservice protocol cleanup (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: gen js Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/standalone/vmservice/isolate_function_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/vmservice/test_helper.dart
diff --git a/tests/standalone/vmservice/test_helper.dart b/tests/standalone/vmservice/test_helper.dart
index 95916478ed31c090bb32e9089fdc5bf6ffdc0967..0d98bfb0168f3741e801058f88a40cc85f05a729 100644
--- a/tests/standalone/vmservice/test_helper.dart
+++ b/tests/standalone/vmservice/test_helper.dart
@@ -208,22 +208,22 @@ class ClassTableHelper {
Expect.equals('ClassList', classTable['type'], 'Not a ClassTable.');
}
- bool classExists(String user_name) {
+ bool classExists(String name) {
List members = classTable['members'];
for (var i = 0; i < members.length; i++) {
Map klass = members[i];
- if (klass['user_name'] == user_name) {
+ if (klass['name'] == name) {
return true;
}
}
return false;
}
- String classId(String user_name) {
+ String classId(String name) {
List members = classTable['members'];
for (var i = 0; i < members.length; i++) {
Map klass = members[i];
- if (klass['user_name'] == user_name) {
+ if (klass['name'] == name) {
return klass['id'];
}
}
@@ -259,7 +259,7 @@ class ClassFieldRequestHelper extends VmServiceRequestHelper {
List<Future> requests = new List<Future>();
fieldNames.forEach((fn) {
class_fields.forEach((f) {
- if (f['user_name'] == fn) {
+ if (f['name'] == fn) {
var request = new FieldRequestHelper(port_, isolate_id_, f['id']);
requests.add(request.makeRequest());
}
@@ -267,7 +267,7 @@ class ClassFieldRequestHelper extends VmServiceRequestHelper {
});
return Future.wait(requests).then((a) {
a.forEach((FieldRequestHelper field) {
- fields[field.field['user_name']] = field.field;
+ fields[field.field['name']] = field.field;
});
return this;
});
« no previous file with comments | « tests/standalone/vmservice/isolate_function_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698