Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Unified Diff: tests/standalone/vmservice/isolate_class_field_test.dart

Issue 487023003: vmservice protocol cleanup (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: gen js Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/service_test.cc ('k') | tests/standalone/vmservice/isolate_code_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/vmservice/isolate_class_field_test.dart
diff --git a/tests/standalone/vmservice/isolate_class_field_test.dart b/tests/standalone/vmservice/isolate_class_field_test.dart
index dd3f44e62a8eaeea2b49f4c0a15fdc117c144711..911ab795ae765ea36d907529f3de7e50d6603286 100644
--- a/tests/standalone/vmservice/isolate_class_field_test.dart
+++ b/tests/standalone/vmservice/isolate_class_field_test.dart
@@ -16,7 +16,6 @@ class BananaClassTest {
_testFieldA(Map field) {
Expect.equals('Field', field['type']);
- Expect.equals('a', field['user_name']);
Expect.equals('a', field['name']);
Expect.equals(false, field['final']);
Expect.equals(false, field['static']);
@@ -28,9 +27,8 @@ class BananaClassTest {
_testFieldFinalFixedLengthList(Map field) {
Expect.equals('Field', field['type']);
- Expect.equals('final_fixed_length_list', field['user_name']);
Expect.equals('final_fixed_length_list', field['name']);
- Expect.equals('_Float32Array', field['guard_class']['user_name']);
+ Expect.equals('_Float32Array', field['guard_class']['name']);
Expect.equals(true, field['final']);
Expect.equals(false, field['static']);
Expect.equals(false, field['const']);
@@ -39,23 +37,21 @@ class BananaClassTest {
_testFieldFixedLengthList(Map field) {
Expect.equals('Field', field['type']);
- Expect.equals('fixed_length_list', field['user_name']);
Expect.equals('fixed_length_list', field['name']);
Expect.equals(false, field['final']);
Expect.equals(false, field['static']);
Expect.equals(false, field['const']);
- Expect.equals('_Float32Array', field['guard_class']['user_name']);
+ Expect.equals('_Float32Array', field['guard_class']['name']);
Expect.equals('variable', field['guard_length']);
}
_testFieldName(Map field) {
Expect.equals('Field', field['type']);
- Expect.equals('name', field['user_name']);
Expect.equals('name', field['name']);
Expect.equals(false, field['final']);
Expect.equals(false, field['static']);
Expect.equals(false, field['const']);
- Expect.equals('_OneByteString', field['guard_class']['user_name']);
+ Expect.equals('_OneByteString', field['guard_class']['name']);
Expect.equals(false, field['guard_nullable']);
Expect.equals('variable', field['guard_length']);
}
@@ -81,33 +77,30 @@ class BadBananaClassTest {
_testFieldV(Map field) {
Expect.equals('Field', field['type']);
- Expect.equals('v', field['user_name']);
Expect.equals('v', field['name']);
Expect.equals(false, field['final']);
Expect.equals(false, field['static']);
Expect.equals(false, field['const']);
- Expect.equals('_Double', field['guard_class']['user_name']);
+ Expect.equals('_Double', field['guard_class']['name']);
Expect.equals(true, field['guard_nullable']);
Expect.equals('variable', field['guard_length']);
}
_testFieldC(Map field) {
Expect.equals('Field', field['type']);
- Expect.equals('c', field['user_name']);
Expect.equals('c', field['name']);
Expect.equals(true, field['final']);
Expect.equals(false, field['static']);
Expect.equals(true, field['final']);
- Expect.equals('_Smi', field['guard_class']['user_name']);
+ Expect.equals('_Smi', field['guard_class']['name']);
Expect.equals(false, field['guard_nullable']);
Expect.equals('variable', field['guard_length']);
}
_testFieldFinalFixedLengthList(Map field) {
Expect.equals('Field', field['type']);
- Expect.equals('final_fixed_length_list', field['user_name']);
Expect.equals('final_fixed_length_list', field['name']);
- Expect.equals('_Float32Array', field['guard_class']['user_name']);
+ Expect.equals('_Float32Array', field['guard_class']['name']);
Expect.equals(true, field['final']);
Expect.equals(false, field['static']);
Expect.equals(false, field['const']);
@@ -116,9 +109,8 @@ class BadBananaClassTest {
_testFieldFixedLengthArray(Map field) {
Expect.equals('Field', field['type']);
- Expect.equals('fixed_length_array', field['user_name']);
Expect.equals('fixed_length_array', field['name']);
- Expect.equals('_List', field['guard_class']['user_name']);
+ Expect.equals('_List', field['guard_class']['name']);
Expect.equals(true, field['final']);
Expect.equals(false, field['static']);
Expect.equals(false, field['const']);
« no previous file with comments | « runtime/vm/service_test.cc ('k') | tests/standalone/vmservice/isolate_code_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698