Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(702)

Issue 486003003: Start using code-generated protocol classes in analysis server. (Closed)

Created:
6 years, 4 months ago by Paul Berry
Modified:
6 years, 4 months ago
Reviewers:
jwren, scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Start using code-generated protocol classes in analysis server. This updates the handlers for analysis.getErrors, server.setSubscriptions, and analysis.setSubscriptions with simpler versions that make use of the code-generated protocol classes, and replaces the classes AnalysisError and AnalysisService with their code-generated versions. It also removes some dead code. R=jwren@google.com Committed: https://code.google.com/p/dart/source/detail?r=39376

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -235 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 2 chunks +2 lines, -28 lines 0 comments Download
M pkg/analysis_server/lib/src/computer/error.dart View 2 chunks +26 lines, -71 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_analysis.dart View 3 chunks +5 lines, -10 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_server.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/edit/edit_domain.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/edit/fix.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/operation/operation_analysis.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/protocol.dart View 3 chunks +0 lines, -66 lines 0 comments Download
M pkg/analysis_server/test/analysis/get_errors_test.dart View 3 chunks +4 lines, -5 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_errors_test.dart View 4 chunks +7 lines, -8 lines 0 comments Download
M pkg/analysis_server/test/analysis_abstract.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/analysis_notification_highlights_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/analysis_notification_navigation_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/analysis_notification_occurrences_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/analysis_notification_outline_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/analysis_notification_overrides_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/analysis_server_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/computer/error_test.dart View 6 chunks +8 lines, -7 lines 0 comments Download
M pkg/analysis_server/test/domain_analysis_test.dart View 3 chunks +6 lines, -7 lines 0 comments Download
M pkg/analysis_server/test/domain_server_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/protocol_test.dart View 1 chunk +1 line, -24 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Paul Berry
6 years, 4 months ago (2014-08-19 00:12:58 UTC) #1
jwren
LGTM
6 years, 4 months ago (2014-08-19 18:22:46 UTC) #2
Paul Berry
Committed patchset #1 manually as 39376 (presubmit successful).
6 years, 4 months ago (2014-08-19 18:29:53 UTC) #3
scheglov
6 years, 4 months ago (2014-08-19 22:56:03 UTC) #4
Message was sent while issue was closed.
LGTM

Looks great!

Powered by Google App Engine
This is Rietveld 408576698