Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3889)

Unified Diff: pkg/analysis_server/lib/src/domain_analysis.dart

Issue 486003003: Start using code-generated protocol classes in analysis server. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/lib/src/computer/error.dart ('k') | pkg/analysis_server/lib/src/domain_server.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/domain_analysis.dart
diff --git a/pkg/analysis_server/lib/src/domain_analysis.dart b/pkg/analysis_server/lib/src/domain_analysis.dart
index 74f77e96ac4e671bd58a5e32090959b5ff55ac1e..6a7b82c48e6989fce7d483abd0e5d780d9f4e87b 100644
--- a/pkg/analysis_server/lib/src/domain_analysis.dart
+++ b/pkg/analysis_server/lib/src/domain_analysis.dart
@@ -11,6 +11,7 @@ import 'package:analysis_server/src/computer/computer_hover.dart';
import 'package:analysis_server/src/computer/error.dart';
import 'package:analysis_server/src/constants.dart';
import 'package:analysis_server/src/protocol.dart';
+import 'package:analysis_server/src/protocol2.dart';
import 'package:analysis_server/src/services/correction/change.dart';
import 'package:analyzer/src/generated/ast.dart';
import 'package:analyzer/src/generated/engine.dart';
@@ -35,7 +36,7 @@ class AnalysisDomainHandler implements RequestHandler {
* Implement the `analysis.getErrors` request.
*/
Response getErrors(Request request) {
- String file = request.getRequiredParameter(FILE).asString();
+ String file = new AnalysisGetErrorsParams.fromRequest(request).file;
server.onFileAnalysisComplete(file).then((_) {
Response response = new Response(request.id);
AnalysisErrorInfo errorInfo = server.getErrors(file);
@@ -140,16 +141,10 @@ class AnalysisDomainHandler implements RequestHandler {
// parse subscriptions
Map<AnalysisService, Set<String>> subMap;
{
- RequestDatum subDatum = request.getRequiredParameter(SUBSCRIPTIONS);
- Map<String, List<String>> subStringMap = subDatum.asStringListMap();
+ Map<AnalysisService, List<String>> subscriptions =
+ new AnalysisSetSubscriptionsParams.fromRequest(request).subscriptions;
subMap = new HashMap<AnalysisService, Set<String>>();
- subStringMap.forEach((String serviceName, List<String> paths) {
- AnalysisService service =
- Enum2.valueOf(AnalysisService.VALUES, serviceName);
- if (service == null) {
- throw new RequestFailure(
- new Response.unknownAnalysisService(request, serviceName));
- }
+ subscriptions.forEach((AnalysisService service, List<String> paths) {
subMap[service] = new HashSet.from(paths);
});
}
« no previous file with comments | « pkg/analysis_server/lib/src/computer/error.dart ('k') | pkg/analysis_server/lib/src/domain_server.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698