Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2183)

Unified Diff: pkg/analysis_server/test/computer/error_test.dart

Issue 486003003: Start using code-generated protocol classes in analysis server. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/computer/error_test.dart
diff --git a/pkg/analysis_server/test/computer/error_test.dart b/pkg/analysis_server/test/computer/error_test.dart
index 2126de108b7fa46b69fbac361e0c8e19f1565f1b..fd4e1daf912030af3ae33f124e3f43fca7c0d07a 100644
--- a/pkg/analysis_server/test/computer/error_test.dart
+++ b/pkg/analysis_server/test/computer/error_test.dart
@@ -4,8 +4,8 @@
library test.computer.error;
-import 'package:analysis_server/src/computer/element.dart';
import 'package:analysis_server/src/computer/error.dart';
+import 'package:analysis_server/src/protocol2.dart';
import 'package:analysis_server/src/constants.dart';
import 'package:analysis_testing/mocks.dart';
import 'package:analysis_testing/reflective_tests.dart';
@@ -54,7 +54,7 @@ class AnalysisErrorTest {
void test_fromEngine_hasCorrection() {
when(engineError.correction).thenReturn('my correction');
- AnalysisError error = new AnalysisError.fromEngine(lineInfo, engineError);
+ AnalysisError error = analysisErrorFromEngine(lineInfo, engineError);
expect(error.toJson(), {
SEVERITY: 'ERROR',
TYPE: 'COMPILE_TIME_ERROR',
@@ -72,7 +72,7 @@ class AnalysisErrorTest {
void test_fromEngine_noCorrection() {
when(engineError.correction).thenReturn(null);
- AnalysisError error = new AnalysisError.fromEngine(lineInfo, engineError);
+ AnalysisError error = analysisErrorFromEngine(lineInfo, engineError);
expect(error.toJson(), {
SEVERITY: 'ERROR',
TYPE: 'COMPILE_TIME_ERROR',
@@ -89,7 +89,7 @@ class AnalysisErrorTest {
void test_fromEngine_noLineInfo() {
when(engineError.correction).thenReturn(null);
- AnalysisError error = new AnalysisError.fromEngine(null, engineError);
+ AnalysisError error = analysisErrorFromEngine(null, engineError);
expect(error.toJson(), {
SEVERITY: 'ERROR',
TYPE: 'COMPILE_TIME_ERROR',
@@ -118,7 +118,8 @@ class AnalysisErrorTest {
MESSAGE: 'Expected to find \';\'',
CORRECTION: 'my correction'
};
- AnalysisError error = AnalysisError.fromJson(json);
+ AnalysisError error =
+ new AnalysisError.fromJson(new ResponseDecoder(), 'json', json);
{
Location location = error.location;
expect(location.file, '/test.dart');
@@ -128,8 +129,8 @@ class AnalysisErrorTest {
expect(location.startColumn, 11);
}
expect(error.message, "Expected to find ';'");
- expect(error.severity, 'ERROR');
- expect(error.type, 'SYNTACTIC_ERROR');
+ expect(error.severity, ErrorSeverity.ERROR);
+ expect(error.type, ErrorType.SYNTACTIC_ERROR);
expect(error.correction, "my correction");
}
« no previous file with comments | « pkg/analysis_server/test/analysis_server_test.dart ('k') | pkg/analysis_server/test/domain_analysis_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698