Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 482573004: Change analysis server protocol to omit empty lists when optional. (Closed)

Created:
6 years, 4 months ago by Paul Berry
Modified:
6 years, 4 months ago
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Change analysis server protocol to omit empty lists when optional. For object fields of type List that are marked as optional, FromJson code automatically populates the data structure with an empty list when the field is omitted. ToJson code automatically omits the field when its value is an empty list. R=brianwilkerson@google.com, scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=39507

Patch Set 1 #

Total comments: 5

Patch Set 2 : Only apply to lists that are already marked as optional. #

Patch Set 3 : Simplify constructor invocations. #

Patch Set 4 : Simplify constructor invocations. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -25 lines) Patch
M pkg/analysis_server/lib/src/computer/computer_outline.dart View 1 2 5 chunks +5 lines, -6 lines 0 comments Download
M pkg/analysis_server/lib/src/computer/computer_overrides.dart View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/generated_protocol.dart View 1 15 chunks +46 lines, -11 lines 0 comments Download
M pkg/analysis_server/test/analysis_notification_overrides_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/search/type_hierarchy_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/tool/spec/codegen_dart_protocol.dart View 7 chunks +44 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Paul Berry
As discussed yesterday. Jaime: I'm not sure the best way to address this on the ...
6 years, 4 months ago (2014-08-22 14:41:25 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/482573004/diff/1/pkg/analysis_server/tool/spec/spec_input.html File pkg/analysis_server/tool/spec/spec_input.html (right): https://codereview.chromium.org/482573004/diff/1/pkg/analysis_server/tool/spec/spec_input.html#newcode47 pkg/analysis_server/tool/spec/spec_input.html:47: will always represent empty maps as <tt>{}</tt>. Do ...
6 years, 4 months ago (2014-08-22 15:12:45 UTC) #2
Paul Berry
PTAL. As discussed, the new logic is now applied just to optional lists, making the ...
6 years, 4 months ago (2014-08-22 20:02:13 UTC) #3
scheglov
LGTM
6 years, 4 months ago (2014-08-22 20:04:59 UTC) #4
Brian Wilkerson
LGTM
6 years, 4 months ago (2014-08-23 17:39:53 UTC) #5
Paul Berry
6 years, 4 months ago (2014-08-23 18:03:45 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 manually as 39507 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698