Change analysis server protocol to omit empty lists when optional.

pkg/analysis_server/lib/src/generated_protocol.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 //
 // This file has been automatically generated.  Please do not edit it manually.
 // To regenerate the file, use the script
 // "pkg/analysis_server/spec/generate_files".
 
 part of protocol2;
 
@@ skipping 2481 matching lines @@
    * requested. The index of other elements of the list is unspecified, but
    * correspond to the integers used to reference supertype and subtype items
    * within the items.
    *
    * This field will be absent if the code at the given file and offset does
    * not represent a type, or if the file has not been sufficiently analyzed to
    * allow a type hierarchy to be produced.
    */
   List<TypeHierarchyItem> hierarchyItems;
 
-  SearchGetTypeHierarchyResult({this.hierarchyItems});
+  SearchGetTypeHierarchyResult({this.hierarchyItems}) {
+    if (hierarchyItems == null) {
+      hierarchyItems = <TypeHierarchyItem>[];
+    }
+  }
 
   factory SearchGetTypeHierarchyResult.fromJson(JsonDecoder jsonDecoder, String jsonPath, Object json) {
     if (json == null) {
       json = {};
     }
     if (json is Map) {
       List<TypeHierarchyItem> hierarchyItems;
       if (json.containsKey("hierarchyItems")) {
         hierarchyItems = jsonDecoder._decodeList(jsonPath + ".hierarchyItems", json["hierarchyItems"], (String jsonPath, Object json) => new TypeHierarchyItem.fromJson(jsonDecoder, jsonPath, json));
+      } else {
+        hierarchyItems = <TypeHierarchyItem>[];
       }
       return new SearchGetTypeHierarchyResult(hierarchyItems: hierarchyItems);
     } else {
       throw jsonDecoder.mismatch(jsonPath, "search.getTypeHierarchy result");
     }
   }
 
   factory SearchGetTypeHierarchyResult.fromResponse(Response response) {
     return new SearchGetTypeHierarchyResult.fromJson(
         new ResponseDecoder(), "result", response.result);
   }
 
   Map<String, dynamic> toJson() {
     Map<String, dynamic> result = {};
-    if (hierarchyItems != null) {
+    if (hierarchyItems.isNotEmpty) {
       result["hierarchyItems"] = hierarchyItems.map((TypeHierarchyItem value) => value.toJson()).toList();
     }
     return result;
   }
 
   Response toResponse(String id) {
     return new Response(id, result: toJson());
   }
 
   @override
@@ skipping 766 matching lines @@
   /**
    * The ids of source edits that are not known to be valid. An edit is not
    * known to be valid if there was insufficient type information for the
    * server to be able to determine whether or not the code needs to be
    * modified, such as when a member is being renamed and there is a reference
    * to a member from an unknown type. This field will be omitted if the change
    * field is omitted or if there are no potential edits for the refactoring.
    */
   List<String> potentialEdits;
 
-  EditGetRefactoringResult(this.status, {this.feedback, this.change, this.potentialEdits});
+  EditGetRefactoringResult(this.status, {this.feedback, this.change, this.potentialEdits}) {
+    if (potentialEdits == null) {
+      potentialEdits = <String>[];
+    }
+  }
 
   factory EditGetRefactoringResult.fromJson(JsonDecoder jsonDecoder, String jsonPath, Object json) {
     if (json == null) {
       json = {};
     }
     if (json is Map) {
       List<RefactoringProblem> status;
       if (json.containsKey("status")) {
         status = jsonDecoder._decodeList(jsonPath + ".status", json["status"], (String jsonPath, Object json) => new RefactoringProblem.fromJson(jsonDecoder, jsonPath, json));
       } else {
         throw jsonDecoder.missingKey(jsonPath, "status");
       }
       Object feedback;
       if (json.containsKey("feedback")) {
         feedback = json["feedback"];
       }
       SourceChange change;
       if (json.containsKey("change")) {
         change = new SourceChange.fromJson(jsonDecoder, jsonPath + ".change", json["change"]);
       }
       List<String> potentialEdits;
       if (json.containsKey("potentialEdits")) {
         potentialEdits = jsonDecoder._decodeList(jsonPath + ".potentialEdits", json["potentialEdits"], jsonDecoder._decodeString);
+      } else {
+        potentialEdits = <String>[];
       }
       return new EditGetRefactoringResult(status, feedback: feedback, change: change, potentialEdits: potentialEdits);
     } else {
       throw jsonDecoder.mismatch(jsonPath, "edit.getRefactoring result");
     }
   }
 
   factory EditGetRefactoringResult.fromResponse(Response response) {
     return new EditGetRefactoringResult.fromJson(
         new ResponseDecoder(), "result", response.result);
   }
 
   Map<String, dynamic> toJson() {
     Map<String, dynamic> result = {};
     result["status"] = status.map((RefactoringProblem value) => value.toJson()).toList();
     if (feedback != null) {
       result["feedback"] = feedback;
     }
     if (change != null) {
       result["change"] = change.toJson();
     }
-    if (potentialEdits != null) {
+    if (potentialEdits.isNotEmpty) {
       result["potentialEdits"] = potentialEdits;
     }
     return result;
   }
 
   Response toResponse(String id) {
     return new Response(id, result: toJson());
   }
 
   @override
@@ skipping 1238 matching lines @@
    * argument list.
    */
   String parameterName;
 
   /**
    * The type of the options parameter being suggested. This field is omitted
    * if the parameterName field is omitted.
    */
   String parameterType;
 
-  CompletionSuggestion(this.kind, this.relevance, this.completion, this.selectionOffset, this.selectionLength, this.isDeprecated, this.isPotential, {this.docSummary, this.docComplete, this.declaringType, this.returnType, this.parameterNames, this.parameterTypes, this.requiredParameterCount, this.positionalParameterCount, this.parameterName, this.parameterType});
+  CompletionSuggestion(this.kind, this.relevance, this.completion, this.selectionOffset, this.selectionLength, this.isDeprecated, this.isPotential, {this.docSummary, this.docComplete, this.declaringType, this.returnType, this.parameterNames, this.parameterTypes, this.requiredParameterCount, this.positionalParameterCount, this.parameterName, this.parameterType}) {
+    if (parameterNames == null) {
+      parameterNames = <String>[];
+    }
+    if (parameterTypes == null) {
+      parameterTypes = <String>[];
+    }
+  }
 
   factory CompletionSuggestion.fromJson(JsonDecoder jsonDecoder, String jsonPath, Object json) {
     if (json == null) {
       json = {};
     }
     if (json is Map) {
       CompletionSuggestionKind kind;
       if (json.containsKey("kind")) {
         kind = new CompletionSuggestionKind.fromJson(jsonDecoder, jsonPath + ".kind", json["kind"]);
       } else {
@@ skipping 47 matching lines @@
       if (json.containsKey("declaringType")) {
         declaringType = jsonDecoder._decodeString(jsonPath + ".declaringType", json["declaringType"]);
       }
       String returnType;
       if (json.containsKey("returnType")) {
         returnType = jsonDecoder._decodeString(jsonPath + ".returnType", json["returnType"]);
       }
       List<String> parameterNames;
       if (json.containsKey("parameterNames")) {
         parameterNames = jsonDecoder._decodeList(jsonPath + ".parameterNames", json["parameterNames"], jsonDecoder._decodeString);
+      } else {
+        parameterNames = <String>[];
       }
       List<String> parameterTypes;
       if (json.containsKey("parameterTypes")) {
         parameterTypes = jsonDecoder._decodeList(jsonPath + ".parameterTypes", json["parameterTypes"], jsonDecoder._decodeString);
+      } else {
+        parameterTypes = <String>[];
       }
       int requiredParameterCount;
       if (json.containsKey("requiredParameterCount")) {
         requiredParameterCount = jsonDecoder._decodeInt(jsonPath + ".requiredParameterCount", json["requiredParameterCount"]);
       }
       int positionalParameterCount;
       if (json.containsKey("positionalParameterCount")) {
         positionalParameterCount = jsonDecoder._decodeInt(jsonPath + ".positionalParameterCount", json["positionalParameterCount"]);
       }
       String parameterName;
@@ skipping 24 matching lines @@
     }
     if (docComplete != null) {
       result["docComplete"] = docComplete;
     }
     if (declaringType != null) {
       result["declaringType"] = declaringType;
     }
     if (returnType != null) {
       result["returnType"] = returnType;
     }
-    if (parameterNames != null) {
+    if (parameterNames.isNotEmpty) {
       result["parameterNames"] = parameterNames;
     }
-    if (parameterTypes != null) {
+    if (parameterTypes.isNotEmpty) {
       result["parameterTypes"] = parameterTypes;
     }
     if (requiredParameterCount != null) {
       result["requiredParameterCount"] = requiredParameterCount;
     }
     if (positionalParameterCount != null) {
       result["positionalParameterCount"] = positionalParameterCount;
     }
     if (parameterName != null) {
       result["parameterName"] = parameterName;
@@ skipping 2126 matching lines @@
    * The length of the element.
    */
   int length;
 
   /**
    * The children of the node. The field will be omitted if the node has no
    * children.
    */
   List<Outline> children;
 
-  Outline(this.element, this.offset, this.length, {this.children});
+  Outline(this.element, this.offset, this.length, {this.children}) {
+    if (children == null) {
+      children = <Outline>[];
+    }
+  }
 
   factory Outline.fromJson(JsonDecoder jsonDecoder, String jsonPath, Object json) {
     if (json == null) {
       json = {};
     }
     if (json is Map) {
       Element element;
       if (json.containsKey("element")) {
         element = new Element.fromJson(jsonDecoder, jsonPath + ".element", json["element"]);
       } else {
         throw jsonDecoder.missingKey(jsonPath, "element");
       }
       int offset;
       if (json.containsKey("offset")) {
         offset = jsonDecoder._decodeInt(jsonPath + ".offset", json["offset"]);
       } else {
         throw jsonDecoder.missingKey(jsonPath, "offset");
       }
       int length;
       if (json.containsKey("length")) {
         length = jsonDecoder._decodeInt(jsonPath + ".length", json["length"]);
       } else {
         throw jsonDecoder.missingKey(jsonPath, "length");
       }
       List<Outline> children;
       if (json.containsKey("children")) {
         children = jsonDecoder._decodeList(jsonPath + ".children", json["children"], (String jsonPath, Object json) => new Outline.fromJson(jsonDecoder, jsonPath, json));
+      } else {
+        children = <Outline>[];
       }
       return new Outline(element, offset, length, children: children);
     } else {
       throw jsonDecoder.mismatch(jsonPath, "Outline");
     }
   }
 
   Map<String, dynamic> toJson() {
     Map<String, dynamic> result = {};
     result["element"] = element.toJson();
     result["offset"] = offset;
     result["length"] = length;
-    if (children != null) {
+    if (children.isNotEmpty) {
       result["children"] = children.map((Outline value) => value.toJson()).toList();
     }
     return result;
   }
 
   @override
   String toString() => JSON.encode(toJson());
 
   @override
   bool operator==(other) {
@@ skipping 45 matching lines @@
    */
   OverriddenMember superclassMember;
 
   /**
    * The members inherited from interfaces that are overridden by the
    * overriding member. The field is omitted if there are no interface members,
    * in which case there must be a superclass member.
    */
   List<OverriddenMember> interfaceMembers;
 
-  Override(this.offset, this.length, {this.superclassMember, this.interfaceMembers});
+  Override(this.offset, this.length, {this.superclassMember, this.interfaceMembers}) {
+    if (interfaceMembers == null) {
+      interfaceMembers = <OverriddenMember>[];
+    }
+  }
 
   factory Override.fromJson(JsonDecoder jsonDecoder, String jsonPath, Object json) {
     if (json == null) {
       json = {};
     }
     if (json is Map) {
       int offset;
       if (json.containsKey("offset")) {
         offset = jsonDecoder._decodeInt(jsonPath + ".offset", json["offset"]);
       } else {
         throw jsonDecoder.missingKey(jsonPath, "offset");
       }
       int length;
       if (json.containsKey("length")) {
         length = jsonDecoder._decodeInt(jsonPath + ".length", json["length"]);
       } else {
         throw jsonDecoder.missingKey(jsonPath, "length");
       }
       OverriddenMember superclassMember;
       if (json.containsKey("superclassMember")) {
         superclassMember = new OverriddenMember.fromJson(jsonDecoder, jsonPath + ".superclassMember", json["superclassMember"]);
       }
       List<OverriddenMember> interfaceMembers;
       if (json.containsKey("interfaceMembers")) {
         interfaceMembers = jsonDecoder._decodeList(jsonPath + ".interfaceMembers", json["interfaceMembers"], (String jsonPath, Object json) => new OverriddenMember.fromJson(jsonDecoder, jsonPath, json));
+      } else {
+        interfaceMembers = <OverriddenMember>[];
       }
       return new Override(offset, length, superclassMember: superclassMember, interfaceMembers: interfaceMembers);
     } else {
       throw jsonDecoder.mismatch(jsonPath, "Override");
     }
   }
 
   Map<String, dynamic> toJson() {
     Map<String, dynamic> result = {};
     result["offset"] = offset;
     result["length"] = length;
     if (superclassMember != null) {
       result["superclassMember"] = superclassMember.toJson();
     }
-    if (interfaceMembers != null) {
+    if (interfaceMembers.isNotEmpty) {
       result["interfaceMembers"] = interfaceMembers.map((OverriddenMember value) => value.toJson()).toList();
     }
     return result;
   }
 
   @override
   String toString() => JSON.encode(toJson());
 
   @override
   bool operator==(other) {
@@ skipping 2031 matching lines @@
     return false;
   }
 
   @override
   int get hashCode {
     int hash = 0;
     hash = _JenkinsSmiHash.combine(hash, newName.hashCode);
     return _JenkinsSmiHash.finish(hash);
   }
 }