Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Side by Side Diff: pkg/analysis_server/lib/src/computer/computer_overrides.dart

Issue 482573004: Change analysis server protocol to omit empty lists when optional. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Simplify constructor invocations. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library computer.overrides; 5 library computer.overrides;
6 6
7 import 'package:analysis_server/src/protocol2.dart'; 7 import 'package:analysis_server/src/protocol2.dart';
8 import 'package:analyzer/src/generated/ast.dart'; 8 import 'package:analyzer/src/generated/ast.dart';
9 import 'package:analyzer/src/generated/element.dart' as engine; 9 import 'package:analyzer/src/generated/element.dart' as engine;
10 10
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
66 // is there any override? 66 // is there any override?
67 if (superEngineElement != null || interfaceEngineElements.isNotEmpty) { 67 if (superEngineElement != null || interfaceEngineElements.isNotEmpty) {
68 OverriddenMember superMember = superEngineElement != null ? 68 OverriddenMember superMember = superEngineElement != null ?
69 new OverriddenMember.fromEngine(superEngineElement) : 69 new OverriddenMember.fromEngine(superEngineElement) :
70 null; 70 null;
71 List<OverriddenMember> interfaceMembers = 71 List<OverriddenMember> interfaceMembers =
72 interfaceEngineElements.map((engine.Element member) => 72 interfaceEngineElements.map((engine.Element member) =>
73 new OverriddenMember.fromEngine(member)).toList(); 73 new OverriddenMember.fromEngine(member)).toList();
74 _overrides.add( 74 _overrides.add(
75 new Override(offset, length, superclassMember: superMember, 75 new Override(offset, length, superclassMember: superMember,
76 interfaceMembers: interfaceMembers.isNotEmpty ? 76 interfaceMembers: interfaceMembers));
77 interfaceMembers : null));
78 } 77 }
79 } 78 }
80 79
81 static engine.Element _lookupMember(engine.ClassElement classElement, 80 static engine.Element _lookupMember(engine.ClassElement classElement,
82 String name) { 81 String name) {
83 if (classElement == null) { 82 if (classElement == null) {
84 return null; 83 return null;
85 } 84 }
86 engine.LibraryElement library = classElement.library; 85 engine.LibraryElement library = classElement.library;
87 // method 86 // method
88 engine.Element member = classElement.lookUpMethod(name, library); 87 engine.Element member = classElement.lookUpMethod(name, library);
89 if (member != null) { 88 if (member != null) {
90 return member; 89 return member;
91 } 90 }
92 // getter 91 // getter
93 member = classElement.lookUpGetter(name, library); 92 member = classElement.lookUpGetter(name, library);
94 if (member != null) { 93 if (member != null) {
95 return member; 94 return member;
96 } 95 }
97 // setter 96 // setter
98 member = classElement.lookUpSetter(name + '=', library); 97 member = classElement.lookUpSetter(name + '=', library);
99 if (member != null) { 98 if (member != null) {
100 return member; 99 return member;
101 } 100 }
102 // not found 101 // not found
103 return null; 102 return null;
104 } 103 }
105 } 104 }
OLDNEW
« no previous file with comments | « pkg/analysis_server/lib/src/computer/computer_outline.dart ('k') | pkg/analysis_server/lib/src/generated_protocol.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698