Issue 480343003: - Address review comments from https://codereview.chromium.org/474913004/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 480343003: - Address review comments from https://codereview.chromium.org/474913004/ (Closed)

Created:
6 years, 4 months ago by Ivan Posva

Modified:
6 years, 4 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

- Address review comments from https://codereview.chromium.org/474913004/ - Clearly mark overrides of ThreadPool::Task::Run as virtual. Committed: https://code.google.com/p/dart/source/detail?r=39418

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -11 lines)			Patch
M	runtime/vm/heap.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/message_handler.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/pages.cc	View	3 chunks	+6 lines, -3 lines	0 comments	Download
M	runtime/vm/snapshot.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/thread_android.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/thread_pool_test.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 3 (0 generated)

Ivan Posva

Committed patchset #1 manually as r39418 (presubmit successful).

6 years, 4 months ago (2014-08-20 18:37:37 UTC) #2

Message was sent while issue was closed.

lgtm