Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: runtime/vm/thread_pool_test.cc

Issue 480343003: - Address review comments from https://codereview.chromium.org/474913004/ (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/thread_android.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/thread_pool_test.cc
===================================================================
--- runtime/vm/thread_pool_test.cc (revision 39411)
+++ runtime/vm/thread_pool_test.cc (working copy)
@@ -35,7 +35,7 @@
: sync_(sync), done_(done) {
}
- void Run() {
+ virtual void Run() {
MonitorLocker ml(sync_);
*done_ = true;
ml.Notify();
@@ -92,7 +92,7 @@
: millis_(millis) {
}
- void Run() {
+ virtual void Run() {
OS::Sleep(millis_);
}
@@ -166,7 +166,7 @@
: pool_(pool), sync_(sync), todo_(todo), total_(total), done_(done) {
}
- void Run() {
+ virtual void Run() {
todo_--; // Subtract one for current task.
int child_todo = todo_ / 2;
« no previous file with comments | « runtime/vm/thread_android.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698