Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Side by Side Diff: runtime/vm/snapshot.h

Issue 480343003: - Address review comments from https://codereview.chromium.org/474913004/ (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/pages.cc ('k') | runtime/vm/thread_android.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef VM_SNAPSHOT_H_ 5 #ifndef VM_SNAPSHOT_H_
6 #define VM_SNAPSHOT_H_ 6 #define VM_SNAPSHOT_H_
7 7
8 #include "platform/assert.h" 8 #include "platform/assert.h"
9 #include "vm/allocation.h" 9 #include "vm/allocation.h"
10 #include "vm/bitfield.h" 10 #include "vm/bitfield.h"
(...skipping 317 matching lines...) Expand 10 before | Expand all | Expand 10 after
328 reference_ = other.reference_; 328 reference_ = other.reference_;
329 state_ = other.state_; 329 state_ = other.state_;
330 return *this; 330 return *this;
331 } 331 }
332 332
333 private: 333 private:
334 Object* reference_; 334 Object* reference_;
335 DeserializeState state_; 335 DeserializeState state_;
336 }; 336 };
337 337
338 PageSpace* old_space() { return old_space_; } 338 PageSpace* old_space() const { return old_space_; }
339 339
340 // Allocate uninitialized objects, this is used when reading a full snapshot. 340 // Allocate uninitialized objects, this is used when reading a full snapshot.
341 RawObject* AllocateUninitialized(intptr_t class_id, intptr_t size); 341 RawObject* AllocateUninitialized(intptr_t class_id, intptr_t size);
342 342
343 RawClass* ReadClassId(intptr_t object_id); 343 RawClass* ReadClassId(intptr_t object_id);
344 RawObject* ReadObjectImpl(); 344 RawObject* ReadObjectImpl();
345 RawObject* ReadObjectImpl(intptr_t header); 345 RawObject* ReadObjectImpl(intptr_t header);
346 RawObject* ReadObjectRef(); 346 RawObject* ReadObjectRef();
347 347
348 // Read a VM isolate object that was serialized as an Id. 348 // Read a VM isolate object that was serialized as an Id.
(...skipping 371 matching lines...) Expand 10 before | Expand all | Expand 10 after
720 private: 720 private:
721 SnapshotWriter* writer_; 721 SnapshotWriter* writer_;
722 bool as_references_; 722 bool as_references_;
723 723
724 DISALLOW_COPY_AND_ASSIGN(SnapshotWriterVisitor); 724 DISALLOW_COPY_AND_ASSIGN(SnapshotWriterVisitor);
725 }; 725 };
726 726
727 } // namespace dart 727 } // namespace dart
728 728
729 #endif // VM_SNAPSHOT_H_ 729 #endif // VM_SNAPSHOT_H_
OLDNEW
« no previous file with comments | « runtime/vm/pages.cc ('k') | runtime/vm/thread_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698