Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 47513007: Fix the more specific relation. (Closed)

Created:
7 years, 1 month ago by Johnni Winther
Modified:
7 years, 1 month ago
Reviewers:
karlklose
CC:
reviews_dartlang.org, scheglov
Visibility:
Public.

Description

Fix the more specific relation. BUG=http://dartbug.com/14358,http://dartbug.com/14362,http://dartbug.com/14364 R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=29446

Patch Set 1 #

Patch Set 2 : Rebase + fix test/status #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -126 lines) Patch
M sdk/lib/_internal/compiler/implementation/dart_types.dart View 3 chunks +9 lines, -4 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/typechecker.dart View 1 chunk +7 lines, -15 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/warnings.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M tests/compiler/dart2js/subtype_test.dart View 22 chunks +61 lines, -60 lines 0 comments Download
M tests/compiler/dart2js/type_checker_test.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M tests/language/language_analyzer.status View 1 2 chunks +5 lines, -9 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 2 chunks +5 lines, -9 lines 0 comments Download
M tests/language/type_promotion_closure_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/language/type_promotion_functions_test.dart View 4 chunks +10 lines, -10 lines 0 comments Download
M tests/language/type_promotion_more_specific_test.dart View 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Johnni Winther
7 years, 1 month ago (2013-10-28 13:29:14 UTC) #1
karlklose
LGTM.
7 years, 1 month ago (2013-10-29 07:39:40 UTC) #2
Johnni Winther
7 years, 1 month ago (2013-10-29 13:19:56 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r29446 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698