Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: tests/language/type_promotion_functions_test.dart

Issue 47513007: Fix the more specific relation. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Rebase + fix test/status Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/language/type_promotion_functions_test.dart
diff --git a/tests/language/type_promotion_functions_test.dart b/tests/language/type_promotion_functions_test.dart
index e6cc0c46a249a6cf0be1d1d45aab7ecfc51076c7..daa317d190b450d0dc434a9f1907b27e780d726b 100644
--- a/tests/language/type_promotion_functions_test.dart
+++ b/tests/language/type_promotion_functions_test.dart
@@ -37,10 +37,11 @@ testFuncAtoDyn() {
b = funcAtoDyn(new B());
c = funcAtoDyn(new C()); /// 01: static type warning
- if (funcAtoDyn is FuncDynToDyn) { // Promotion: FuncDynToDyn << FuncAtoDyn.
+ if (funcAtoDyn is FuncDynToDyn) {
+ // No promotion: FuncDynToDyn !<< FuncAtoDyn.
a = funcAtoDyn(new A());
b = funcAtoDyn(new B());
- c = funcAtoDyn(new C());
+ c = funcAtoDyn(new C()); /// 11: static type warning
}
}
@@ -50,11 +51,10 @@ testFuncDynToDyn() {
b = funcDynToDyn(new B());
c = funcDynToDyn(new C());
- if (funcDynToDyn is FuncAtoDyn) {
- // No promotion: FuncAtoDyn !<< FuncDynToDyn.
+ if (funcDynToDyn is FuncAtoDyn) { // Promotion: FuncAtoDyn << FuncDynToDyn.
a = funcDynToDyn(new A());
b = funcDynToDyn(new B());
- c = funcDynToDyn(new C());
+ c = funcDynToDyn(new C()); /// 09: static type warning
}
if (funcDynToDyn is FuncDynToVoid) {
@@ -64,11 +64,10 @@ testFuncDynToDyn() {
c = funcDynToDyn(new C());
}
- if (funcDynToDyn is FuncDynToA) {
- // No promotion: FuncDynToA !<< FuncDynToDyn.
+ if (funcDynToDyn is FuncDynToA) { // Promotion: FuncDynToA << FuncDynToDyn.
a = funcDynToDyn(new A());
b = funcDynToDyn(new B());
- c = funcDynToDyn(new C());
+ c = funcDynToDyn(new C()); /// 10: static type warning
}
}
@@ -98,10 +97,11 @@ testFuncDynToA() {
b = funcDynToA(new B());
c = funcDynToA(new C()); /// 06: static type warning
- if (funcDynToA is FuncDynToDyn) { // Promotion: FuncDynToDyn << FuncDynToA.
+ if (funcDynToA is FuncDynToDyn) {
+ // No promotion: FuncDynToDyn !<< FuncDynToA.
a = funcDynToA(new A());
b = funcDynToA(new B());
- c = funcDynToA(new C());
+ c = funcDynToA(new C()); /// 08: static type warning
}
if (funcDynToA is FuncDynToVoid) {
« no previous file with comments | « tests/language/type_promotion_closure_test.dart ('k') | tests/language/type_promotion_more_specific_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698