Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Side by Side Diff: sdk/lib/_internal/compiler/implementation/warnings.dart

Issue 47513007: Fix the more specific relation. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Rebase + fix test/status Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of dart2js; 5 part of dart2js;
6 6
7 const DONT_KNOW_HOW_TO_FIX = ""; 7 const DONT_KNOW_HOW_TO_FIX = "";
8 8
9 /** 9 /**
10 * The messages in this file should meet the following guide lines: 10 * The messages in this file should meet the following guide lines:
(...skipping 1335 matching lines...) Expand 10 before | Expand all | Expand 10 after
1346 "promotion and potentially mutated in the scope of '#{variableName}'."); 1346 "promotion and potentially mutated in the scope of '#{variableName}'.");
1347 1347
1348 static const MessageKind ACCESSED_IN_CLOSURE_HERE = const MessageKind( 1348 static const MessageKind ACCESSED_IN_CLOSURE_HERE = const MessageKind(
1349 "Info: Variable '#{variableName}' is accessed in a closure here."); 1349 "Info: Variable '#{variableName}' is accessed in a closure here.");
1350 1350
1351 static const MessageKind NOT_MORE_SPECIFIC = const MessageKind( 1351 static const MessageKind NOT_MORE_SPECIFIC = const MessageKind(
1352 "Hint: Variable '#{variableName}' is not shown to have type " 1352 "Hint: Variable '#{variableName}' is not shown to have type "
1353 "'#{shownType}' because '#{shownType}' is not more specific than the " 1353 "'#{shownType}' because '#{shownType}' is not more specific than the "
1354 "known type '#{knownType}' of '#{variableName}'."); 1354 "known type '#{knownType}' of '#{variableName}'.");
1355 1355
1356 static const MessageKind NOT_MORE_SPECIFIC_RAW = const MessageKind(
1357 "Hint: Variable '#{variableName}' is not shown to have type "
1358 "'#{shownType}' because '#{shownType}' is not more specific than the "
1359 "known type '#{knownType}' of '#{variableName}'.",
1360 howToFix: "Try replacing '#{shownType}' with '#{shownTypeRaw}'.");
1361
1362 ////////////////////////////////////////////////////////////////////////////// 1356 //////////////////////////////////////////////////////////////////////////////
1363 // Patch errors start. 1357 // Patch errors start.
1364 ////////////////////////////////////////////////////////////////////////////// 1358 //////////////////////////////////////////////////////////////////////////////
1365 1359
1366 static const MessageKind PATCH_RETURN_TYPE_MISMATCH = const MessageKind( 1360 static const MessageKind PATCH_RETURN_TYPE_MISMATCH = const MessageKind(
1367 "Error: Patch return type '#{patchReturnType}' does not match " 1361 "Error: Patch return type '#{patchReturnType}' does not match "
1368 "'#{originReturnType}' on origin method '#{methodName}'."); 1362 "'#{originReturnType}' on origin method '#{methodName}'.");
1369 1363
1370 static const MessageKind PATCH_REQUIRED_PARAMETER_COUNT_MISMATCH = 1364 static const MessageKind PATCH_REQUIRED_PARAMETER_COUNT_MISMATCH =
1371 const MessageKind( 1365 const MessageKind(
(...skipping 162 matching lines...) Expand 10 before | Expand all | Expand 10 after
1534 1528
1535 class CompileTimeConstantError extends Diagnostic { 1529 class CompileTimeConstantError extends Diagnostic {
1536 CompileTimeConstantError(MessageKind kind, Map arguments, bool terse) 1530 CompileTimeConstantError(MessageKind kind, Map arguments, bool terse)
1537 : super(kind, arguments, terse); 1531 : super(kind, arguments, terse);
1538 } 1532 }
1539 1533
1540 class CompilationError extends Diagnostic { 1534 class CompilationError extends Diagnostic {
1541 CompilationError(MessageKind kind, Map arguments, bool terse) 1535 CompilationError(MessageKind kind, Map arguments, bool terse)
1542 : super(kind, arguments, terse); 1536 : super(kind, arguments, terse);
1543 } 1537 }
OLDNEW
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/typechecker.dart ('k') | tests/compiler/dart2js/subtype_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698