respect show/hide combinators when generating suggestions

respect show/hide combinators when generating suggestions

BUG=
R=scheglov@google.com

Committed: https://code.google.com/p/dart/source/detail?r=39143

[scheglov, 2014-08-12 05:02:22]

LGTM

https://codereview.chromium.org/465843002/diff/1/pkg/analysis_services/lib/co...
File pkg/analysis_services/lib/completion/completion_computer.dart (right):

https://codereview.chromium.org/465843002/diff/1/pkg/analysis_services/lib/co...
pkg/analysis_services/lib/completion/completion_computer.dart:33: bool
computeFast(CompilationUnit unit, AstNode node,
Would you please document [node]?

https://codereview.chromium.org/465843002/diff/1/pkg/analysis_services/lib/sr...
File pkg/analysis_services/lib/src/completion/imported_type_computer.dart
(right):

https://codereview.chromium.org/465843002/diff/1/pkg/analysis_services/lib/sr...
pkg/analysis_services/lib/src/completion/imported_type_computer.dart:79:
LibraryElement lib = directive.element.importedLibrary;
BTW, you get the unit using getParsedCompilationUnit, so it might be not
resolved yet.
Do we need to use getResolvedCompilationUnit() or check if the unit is resolved?

https://codereview.chromium.org/465843002/diff/1/pkg/analysis_services/lib/sr...
pkg/analysis_services/lib/src/completion/imported_type_computer.dart:104: var
show = showNames[lib];
Could we please use type annotations?
I think it is OK to skip them when we create a class instance, but in this case
I have to track it manually in the review tool, what is the type of "show".

"Cmd+1 | Add type annotation" is your friend.

https://codereview.chromium.org/465843002/diff/1/pkg/analysis_services/lib/sr...
pkg/analysis_services/lib/src/completion/imported_type_computer.dart:154:
visitTopLevelVariableElement(TopLevelVariableElement element) {
Do we want to add FunctionTypeAliasElement?
You could use visitElement() to visit CompilationUnitElement children or add a
suggestion and return.

[danrubel, 2014-08-12 14:52:56]

https://codereview.chromium.org/465843002/diff/1/pkg/analysis_services/lib/co...
File pkg/analysis_services/lib/completion/completion_computer.dart (right):

https://codereview.chromium.org/465843002/diff/1/pkg/analysis_services/lib/co...
pkg/analysis_services/lib/completion/completion_computer.dart:33: bool
computeFast(CompilationUnit unit, AstNode node,
On 2014/08/12 05:02:21, scheglov wrote:
> Would you please document [node]?

It is documented in the comment, but perhaps not clear enough. I reworded it so
that hopefully [node] is more clearly defined.

https://codereview.chromium.org/465843002/diff/1/pkg/analysis_services/lib/sr...
File pkg/analysis_services/lib/src/completion/imported_type_computer.dart
(right):

https://codereview.chromium.org/465843002/diff/1/pkg/analysis_services/lib/sr...
pkg/analysis_services/lib/src/completion/imported_type_computer.dart:79:
LibraryElement lib = directive.element.importedLibrary;
On 2014/08/12 05:02:21, scheglov wrote:
> BTW, you get the unit using getParsedCompilationUnit, so it might be not
> resolved yet.
> Do we need to use getResolvedCompilationUnit() or check if the unit is
resolved?

computeFast receives a compilation unit that may not be resolved, but
computeFull is always passed a resolved compilation unit. This method is
indirectly called from computeFull and thus guarenteed a resolved compilation
unit.

https://codereview.chromium.org/465843002/diff/1/pkg/analysis_services/lib/sr...
pkg/analysis_services/lib/src/completion/imported_type_computer.dart:104: var
show = showNames[lib];
On 2014/08/12 05:02:21, scheglov wrote:
> Could we please use type annotations?
> I think it is OK to skip them when we create a class instance, but in this
case
> I have to track it manually in the review tool, what is the type of "show".
> 
> "Cmd+1 | Add type annotation" is your friend.

Done.

https://codereview.chromium.org/465843002/diff/1/pkg/analysis_services/lib/sr...
pkg/analysis_services/lib/src/completion/imported_type_computer.dart:154:
visitTopLevelVariableElement(TopLevelVariableElement element) {
On 2014/08/12 05:02:22, scheglov wrote:
> Do we want to add FunctionTypeAliasElement?
> You could use visitElement() to visit CompilationUnitElement children or add a
> suggestion and return.

Done.

[danrubel, 2014-08-12 14:54:55]

Committed patchset #2 manually as 39143 (presubmit successful).