pkg/analysis_services/test/completion/completion_test_util.dart - Issue 465843002: respect show/hide combinators when generating suggestions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_services/test/completion/completion_test_util.dart

Issue 465843002: respect show/hide combinators when generating suggestions (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: address comments Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_services/test/completion/completion_computer_test.dart ('k') | pkg/analysis_services/test/completion/imported_type_computer_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_services/test/completion/completion_test_util.dart

diff --git a/pkg/analysis_services/test/completion/completion_test_util.dart b/pkg/analysis_services/test/completion/completion_test_util.dart

index d732b6ff6de88022c43bb4f5a5fed7e61d5910a4..91439e8f3a17a2ca54bf29ba62fe47f8860f8516 100644

--- a/pkg/analysis_services/test/completion/completion_test_util.dart

+++ b/pkg/analysis_services/test/completion/completion_test_util.dart

@@ -132,7 +132,8 @@ class AbstractCompletionTest extends AbstractContextTest {

..offset = completionOffset;

suggestions = [];

CompilationUnit unit = context.parseCompilationUnit(testSource);

- return computer.computeFast(unit, suggestions);

+ AstNode node = new NodeLocator.con1(completionOffset).searchWithin(unit);

+ return computer.computeFast(unit, node, suggestions);

}

Future<bool> computeFull() {

@@ -153,7 +154,8 @@ class AbstractCompletionTest extends AbstractContextTest {

expect(library, isNotNull);

var unit = context.getResolvedCompilationUnit(testSource, library);

expect(unit, isNotNull);

- return computer.computeFull(unit, suggestions);

+ AstNode node = new NodeLocator.con1(completionOffset).searchWithin(unit);

+ return computer.computeFull(unit, node, suggestions);

}

@override