respect show/hide combinators when generating suggestions

pkg/analysis_services/lib/completion/completion_computer.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library services.completion.computer;
 
 import 'dart:async';
 
 import 'package:analysis_services/completion/completion_suggestion.dart';
 import 'package:analysis_services/search/search_engine.dart';
 import 'package:analysis_services/src/completion/dart_completion_manager.dart';
 import 'package:analyzer/src/generated/ast.dart';
 import 'package:analyzer/src/generated/engine.dart';
 import 'package:analyzer/src/generated/source.dart';
 
 /**
  * The base class for computing code completion suggestions.
  */
 abstract class CompletionComputer {
   AnalysisContext context;
   Source source;
   int offset;
   SearchEngine searchEngine;
 
   /**
-   * Computes the initial set of [CompletionSuggestion]s based on information
-   * already cached in the analysis context. This method should execute
-   * quickly and not block waiting for any analysis.
+   * Given the compilation unit and the node at the completion offset,
+   * this computes the initial set of [CompletionSuggestion]s based on
+   * information already cached in the analysis context.
+   * This method should execute quickly and not block waiting for any analysis.
    * Returns `true` if the computer's work is complete
    * or `false` if [computeFull] should be called to complete the work.
    */
-  bool computeFast(CompilationUnit unit,
+  bool computeFast(CompilationUnit unit, AstNode node,

[scheglov, 2014/08/12 05:02:21]

Would you please document [node]?

[danrubel, 2014/08/12 14:52:56]

It is documented in the comment, but perhaps not clear enough. I reworded it so
that hopefully [node] is more clearly defined.

       List<CompletionSuggestion> suggestions);
 
   /**
-   * Computes [CompletionSuggestion]s for the specified position in the source.
-   * Returns `true` if the receiver modified the list of suggestions.
+   * Given the resolved compilation unit and the node at the completion offset,
+   * this computes [CompletionSuggestion]s for the specified position in the
+   * source. Returns `true` if the receiver modified the list of suggestions.
    */
-  Future<bool> computeFull(CompilationUnit unit,
+  Future<bool> computeFull(CompilationUnit unit, AstNode node,
       List<CompletionSuggestion> suggestions);
 }
 
 /**
  * Manages `CompletionComputer`s for a given completion request.
  */
 abstract class CompletionManager {
 
   StreamController<CompletionResult> controller;
 
@@ skipping 70 matching lines @@
   final Source source;
   final int offset;
 
   NoOpCompletionManager(this.source, this.offset);
 
   @override
   void compute() {
     controller.add(new CompletionResult(offset, 0, [], true));
   }
 }