Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 46533003: Add Event and Window to transferrable types (Closed)

Created:
7 years, 1 month ago by justinfagnani
Modified:
7 years, 1 month ago
Reviewers:
Jacob
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add Event, HtmlCollection, NodeList and Window to transferrable types BUG= Committed: https://code.google.com/p/dart/source/detail?r=29623

Patch Set 1 #

Patch Set 2 : remove NodeList and HtmlCollection #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -14 lines) Patch
M sdk/lib/js/dart2js/js_dart2js.dart View 1 2 3 4 4 chunks +16 lines, -9 lines 0 comments Download
M sdk/lib/js/dartium/js_dartium.dart View 1 2 3 4 5 2 chunks +7 lines, -3 lines 0 comments Download
M tests/html/js_test.dart View 1 2 3 4 6 chunks +52 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
justinfagnani
Transferring ElementList is blocked on https://codereview.chromium.org/46433003/
7 years, 1 month ago (2013-10-26 01:27:23 UTC) #1
justinfagnani
Removed NodeList and HtmlCollection
7 years, 1 month ago (2013-10-28 19:03:53 UTC) #2
justinfagnani
7 years, 1 month ago (2013-10-31 01:44:02 UTC) #3
Message was sent while issue was closed.
Committed patchset #6 manually as r29623 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698