Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 46433003: Exposing raw DOM lists from wrappers (Closed)

Created:
7 years, 1 month ago by blois
Modified:
6 years, 5 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Exposing raw DOM lists from wrappers This is to make them transferrable via dart:js So basically all of our wrappers implement NodeListWrapper (which is defined in html_common). One can check if the Dart list is a NodeListWrapper, then call rawList if so. The result of rawList is typed as List<Node>, which should be either NodeList or HtmlCollection. BUG=14485 R=justinfagnani@google.com Committed: https://code.google.com/p/dart/source/detail?r=29322

Patch Set 1 #

Total comments: 2

Patch Set 2 : Covering FilteredElementList #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -17 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 9 chunks +16 lines, -6 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 9 chunks +16 lines, -6 lines 0 comments Download
M sdk/lib/html/html_common/filtered_element_list.dart View 1 2 chunks +4 lines, -1 line 1 comment Download
M sdk/lib/html/html_common/lists.dart View 1 chunk +7 lines, -0 lines 0 comments Download
M tools/dom/src/WrappedList.dart View 2 chunks +4 lines, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 1 4 chunks +9 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Node.darttemplate View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
blois
7 years, 1 month ago (2013-10-26 01:03:31 UTC) #1
justinfagnani
Do you also need to update FilteredElementList? https://codereview.chromium.org/46433003/diff/1/tools/dom/templates/html/impl/impl_Element.darttemplate File tools/dom/templates/html/impl/impl_Element.darttemplate (right): https://codereview.chromium.org/46433003/diff/1/tools/dom/templates/html/impl/impl_Element.darttemplate#newcode162 tools/dom/templates/html/impl/impl_Element.darttemplate:162: List<Node> get ...
7 years, 1 month ago (2013-10-26 01:32:26 UTC) #2
blois
https://codereview.chromium.org/46433003/diff/1/tools/dom/templates/html/impl/impl_Element.darttemplate File tools/dom/templates/html/impl/impl_Element.darttemplate (right): https://codereview.chromium.org/46433003/diff/1/tools/dom/templates/html/impl/impl_Element.darttemplate#newcode162 tools/dom/templates/html/impl/impl_Element.darttemplate:162: List<Node> get rawList => _element._childElements; On 2013/10/26 01:32:26, justinfagnani ...
7 years, 1 month ago (2013-10-26 17:55:17 UTC) #3
justinfagnani
lgtm https://codereview.chromium.org/46433003/diff/90001/sdk/lib/html/html_common/filtered_element_list.dart File sdk/lib/html/html_common/filtered_element_list.dart (right): https://codereview.chromium.org/46433003/diff/90001/sdk/lib/html/html_common/filtered_element_list.dart#newcode136 sdk/lib/html/html_common/filtered_element_list.dart:136: List<Node> get rawList => _node.childNodes; could this just ...
7 years, 1 month ago (2013-10-26 20:29:50 UTC) #4
blois
7 years, 1 month ago (2013-10-27 02:26:29 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r29322 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698