Add Event and Window to transferrable types

sdk/lib/js/dart2js/js_dart2js.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Support for interoperating with JavaScript.
  * 
  * This library provides access to JavaScript objects from Dart, allowing
  * Dart code to get and set properties, and call methods of JavaScript objects
  * and invoke JavaScript functions. The library takes care of converting
@@ skipping 42 matching lines @@
  *
  * Functions and closures are proxied in such a way that they are callable. A
  * Dart closure assigned to a JavaScript property is proxied by a function in
  * JavaScript. A JavaScript function accessed from Dart is proxied by a
  * [JsFunction], which has a [apply] method to invoke it.
  *
  * The following types are transferred directly and not proxied:
  *
  * * "Basic" types: `null`, `bool`, `num`, `String`, `DateTime`
  * * `Blob`
+ * * `Event`
+ * * `HtmlCollection`
+ * * `ImageData`
  * * `KeyRange`
- * * `ImageData`
+ * * `Node`
+ * * `NodeList`
  * * `TypedData`, including its subclasses like `Int32List`, but _not_
  *   `ByteBuffer`
- * * `Node`
+ * * `Window`
  *
  * ## Converting collections with JsObject.jsify()
  *
  * To create a JavaScript collection from a Dart collection use the
  * [JsObject.jsify] constructor, which converts Dart [Map]s and [Iterable]s
  * into JavaScript Objects and Arrays.
  *
  * The following expression creats a new JavaScript object with the properties
  * `a` and `b` defined:
  *
  *     var jsMap = new JsObject.jsify({'a': 1, 'b': 2});
  * 
  * This expression creates a JavaScript array:
  *
  *     var jsArray = new JsObject.jsify([1, 2, 3]);
  */
 library dart.js;
 
-import 'dart:html' show Blob, ImageData, Node;
+import 'dart:html' show Blob, Event, ImageData, Node, Window;
 import 'dart:collection' show HashMap, ListMixin;
 import 'dart:indexed_db' show KeyRange;
 import 'dart:typed_data' show TypedData;
 
 import 'dart:_foreign_helper' show JS, DART_CLOSURE_TO_JS;
 import 'dart:_interceptors' show JavaScriptObject, UnknownJavaScriptObject;
 import 'dart:_js_helper' show Primitives, convertDartClosureToJS;
 
 final JsObject context = _wrapToDart(Primitives.computeGlobalThis());
 
@@ skipping 363 matching lines @@
       JS('void', 'Object.defineProperty(#, #, { value: #})', o, name, value);
       return true;
     } catch(e) {
       // object is native and lies about being extensible
       // see https://bugzilla.mozilla.org/show_bug.cgi?id=775185
     }
   }
   return false;
 }
 
+bool _isLocalObject(o) => JS('bool', '# instanceof Object', o);
+
 dynamic _convertToJS(dynamic o) {
   if (o == null) {
     return null;
   } else if (o is String || o is num || o is bool
-      || o is Blob || o is KeyRange || o is ImageData || o is Node
-      || o is TypedData) {
+      || o is Blob || o is Event || o is KeyRange || o is ImageData
+      || o is Node || o is TypedData || o is Window) {
     return o;
   } else if (o is DateTime) {
     return Primitives.lazyAsJsDate(o);
   } else if (o is JsObject) {
     return o._jsObject;
   } else if (o is Function) {
     return _getJsProxy(o, _JS_FUNCTION_PROPERTY_NAME, (o) {
       var jsFunction = _convertDartFunction(o);
       // set a property on the JS closure referencing the Dart closure
       _defineProperty(jsFunction, _DART_CLOSURE_PROPERTY_NAME, o);
@@ skipping 10 matching lines @@
   if (jsProxy == null) {
     jsProxy = createProxy(o);
     _defineProperty(o, propertyName, jsProxy);
   }
   return jsProxy;
 }
 
 // converts a Dart object to a reference to a native JS object
 // which might be a DartObject JS->Dart proxy
 Object _convertToDart(o) {
-  var isArray = JS('bool', '# instanceof Array', o);
   if (JS('bool', '# == null', o) ||
       JS('bool', 'typeof # == "string"', o) ||
       JS('bool', 'typeof # == "number"', o) ||
       JS('bool', 'typeof # == "boolean"', o)) {
     return o;
-  } else if (o is Blob || o is KeyRange || o is ImageData || o is Node
-      || o is TypedData) {
-    return JS('Blob|KeyRange|ImageData|Node|TypedData', '#', o);
+  } else if (_isLocalObject(o)
+      && (o is Blob || o is Event || o is KeyRange || o is ImageData
+      || o is Node || o is TypedData || o is Window)) {
+    // long line: dart2js doesn't allow string concatenation in the JS() form
+    return JS('Blob|Event|KeyRange|ImageData|Node|TypedData|Window', '#', o);
   } else if (JS('bool', '# instanceof Date', o)) {
     var ms = JS('num', '#.getMilliseconds()', o);
     return new DateTime.fromMillisecondsSinceEpoch(ms);
   } else if (JS('bool', '#.constructor === DartObject', o)) {
     return JS('', '#.o', o);
   } else {
     return _wrapToDart(o);
   }
 }
 
@@ skipping 11 matching lines @@
 }
 
 Object _getDartProxy(o, String propertyName, createProxy(o)) {
   var dartProxy = JS('', '#[#]', o, propertyName);
   if (dartProxy == null) {
     dartProxy = createProxy(o);
     _defineProperty(o, propertyName, dartProxy);
   }
   return dartProxy;
 }