Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issue 444743002: Use Blink IDL parser for dart libraries. (Closed)

Created:
6 years, 4 months ago by terry
Modified:
6 years, 3 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Begin hookup of Blink IDL parser for dart:* libraries. BUG= R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=39948 Committed: https://code.google.com/p/dart/source/detail?r=40026

Patch Set 1 #

Patch Set 2 : Latest round of changes #

Patch Set 3 : Latest state of code. #

Patch Set 4 : Handle constructors properly. #

Patch Set 5 : Fixed overloads and collisions of optional args vs non-optional args for DartSuppress. #

Patch Set 6 : minor cleanup #

Patch Set 7 : Changes to run blink IDL parser with go.sh #

Patch Set 8 : Fixed union types #

Patch Set 9 : Cleanup #

Patch Set 10 : Reverted dom.json changes #

Patch Set 11 : cleanup #

Total comments: 16

Patch Set 12 : Fixed callback mapping and overloads allowed. #

Patch Set 13 : Integrated CL suggestions and final changes to make final locations. #

Patch Set 14 : Revert - no changes yet. #

Patch Set 15 : Added support for __propertyQuery__ for CSSStyleDeclaration using existing webidl support #

Patch Set 16 : Re-apply reverted CL #

Patch Set 17 : Merged #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1778 lines, -596 lines) Patch
M tools/dom/idl/dart/dart.idl View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 6 chunks +156 lines, -182 lines 0 comments Download
A tools/dom/new_scripts/code_generator_dart.py View 1 chunk +317 lines, -0 lines 0 comments Download
A tools/dom/new_scripts/compiler.py View 1 chunk +115 lines, -0 lines 0 comments Download
A tools/dom/new_scripts/dart_compiler.py View 1 2 3 4 5 6 7 8 9 10 1 chunk +115 lines, -0 lines 0 comments Download
A tools/dom/new_scripts/dart_utilities.py View 1 chunk +164 lines, -0 lines 0 comments Download
A + tools/dom/scripts/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
M tools/dom/scripts/dartdomgenerator.py View 1 2 3 4 5 6 7 8 9 10 11 12 11 chunks +75 lines, -13 lines 0 comments Download
M tools/dom/scripts/dartgenerator.py View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M tools/dom/scripts/dartmetadata.py View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +3 lines, -1 line 0 comments Download
M tools/dom/scripts/databasebuilder.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 11 chunks +212 lines, -24 lines 0 comments Download
M tools/dom/scripts/fremontcutbuilder.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 5 chunks +32 lines, -11 lines 0 comments Download
M tools/dom/scripts/go.sh View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/scripts/htmldartgenerator.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +1 line, -0 lines 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +13 lines, -5 lines 0 comments Download
M tools/dom/scripts/idlnode.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 18 chunks +264 lines, -54 lines 0 comments Download
M tools/dom/scripts/idlnode_test.py View 1 1 chunk +0 lines, -1 line 0 comments Download
M tools/dom/scripts/monitored.py View 1 2 3 3 chunks +7 lines, -6 lines 0 comments Download
M tools/dom/scripts/multiemitter.py View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M tools/dom/scripts/systemhtml.py View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +3 lines, -1 line 0 comments Download
M tools/dom/src/WebGLConstants.dart View 1 2 3 4 5 6 7 1 chunk +295 lines, -295 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
terry
6 years, 3 months ago (2014-09-03 19:16:51 UTC) #2
vsm
https://codereview.chromium.org/444743002/diff/200001/tools/dom/idl/dart/new_dart.idl File tools/dom/idl/dart/new_dart.idl (right): https://codereview.chromium.org/444743002/diff/200001/tools/dom/idl/dart/new_dart.idl#newcode1 tools/dom/idl/dart/new_dart.idl:1: // This file introduces / supplements and forces Dart ...
6 years, 3 months ago (2014-09-03 22:23:41 UTC) #3
terry
PTAL https://codereview.chromium.org/444743002/diff/200001/tools/dom/idl/dart/new_dart.idl File tools/dom/idl/dart/new_dart.idl (right): https://codereview.chromium.org/444743002/diff/200001/tools/dom/idl/dart/new_dart.idl#newcode1 tools/dom/idl/dart/new_dart.idl:1: // This file introduces / supplements and forces ...
6 years, 3 months ago (2014-09-05 20:22:56 UTC) #4
vsm
lgtm https://codereview.chromium.org/444743002/diff/200001/tools/dom/new_scripts/code_generator_dart.py File tools/dom/new_scripts/code_generator_dart.py (right): https://codereview.chromium.org/444743002/diff/200001/tools/dom/new_scripts/code_generator_dart.py#newcode1 tools/dom/new_scripts/code_generator_dart.py:1: # Copyright (C) 2013 Google Inc. All rights ...
6 years, 3 months ago (2014-09-05 20:33:26 UTC) #5
terry
https://codereview.chromium.org/444743002/diff/200001/tools/dom/new_scripts/code_generator_dart.py File tools/dom/new_scripts/code_generator_dart.py (right): https://codereview.chromium.org/444743002/diff/200001/tools/dom/new_scripts/code_generator_dart.py#newcode1 tools/dom/new_scripts/code_generator_dart.py:1: # Copyright (C) 2013 Google Inc. All rights reserved. ...
6 years, 3 months ago (2014-09-05 20:35:56 UTC) #6
terry
Changed dart.idl to support __propertyQuery__ exposing what's needed in CSSStyleDeclaration using existing web idl mechanism ...
6 years, 3 months ago (2014-09-07 18:40:21 UTC) #7
terry
Committed patchset #15 (id:280001) manually as 39948 (presubmit successful).
6 years, 3 months ago (2014-09-08 02:34:10 UTC) #8
terry
6 years, 3 months ago (2014-09-09 13:18:39 UTC) #9
Message was sent while issue was closed.
Committed patchset #17 (id:320001) manually as 40026 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698