Issue 442293002: Consolidate all range analysis related code in a separate file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 442293002: Consolidate all range analysis related code in a separate file. (Closed)

Created:
6 years, 4 months ago by Vyacheslav Egorov (Google)

Modified:
6 years, 4 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Consolidate all range analysis related code in a separate file. This makes working with it easier, similar to how we have all type propagation code in flow_graph_type_propagator.{cc,h} BUG= R=fschneider@google.com Committed: https://code.google.com/p/dart/source/detail?r=38928

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2457 lines, -3072 lines)			Patch
M	runtime/vm/flow_graph_optimizer.cc	View	4 chunks	+1 line, -916 lines	0 comments	Download
A	runtime/vm/flow_graph_range_analysis.h	View	1 chunk	+495 lines, -0 lines	0 comments	Download
A	runtime/vm/flow_graph_range_analysis.cc	View	1 chunk	+1946 lines, -0 lines	0 comments	Download
A +	runtime/vm/flow_graph_range_analysis_test.cc	View	2 chunks	+3 lines, -34 lines	0 comments	Download
M	runtime/vm/il_printer.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	3 chunks	+2 lines, -347 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	4 chunks	+1 line, -1145 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm64.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_mips.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_test.cc	View	1 chunk	+0 lines, -630 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/vm_sources.gypi	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Vyacheslav Egorov (Google)

PTAL The code was just moved, not changed (except for CheckArrayBoundInstr::IsRedundant() signature to avoid including ...

6 years, 4 months ago (2014-08-06 12:01:55 UTC) #1

Vyacheslav Egorov (Google)

6 years, 4 months ago (2014-08-06 12:44:06 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as 38928 (presubmit successful).