Issue 425083003: Use (more) xor on FP register to load it with 0.0.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 425083003: Use (more) xor on FP register to load it with 0.0. (Closed)

Created:
6 years, 4 months ago by srdjan

Modified:
6 years, 4 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Use (more) xor on FP register to load it with 0.0. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=38706

Patch Set 2 : #

Total comments: 1

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -17 lines)			Patch
M	runtime/vm/flow_graph_compiler_arm.cc	View		1 chunk	+17 lines, -6 lines	1 comment	Download
M	runtime/vm/flow_graph_compiler_arm64.cc	View	1	1 chunk	+12 lines, -4 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View		1 chunk	+13 lines, -5 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm64.cc	View		1 chunk	+7 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://codereview.chromium.org/425083003/diff/20001/runtime/vm/flow_graph_compiler_arm.cc File runtime/vm/flow_graph_compiler_arm.cc (right): https://codereview.chromium.org/425083003/diff/20001/runtime/vm/flow_graph_compiler_arm.cc#newcode1615 runtime/vm/flow_graph_compiler_arm.cc:1615: __ veorq(qdst, qdst, qdst); Why not veord? Mmm, ...

6 years, 4 months ago (2014-07-29 21:43:17 UTC) #2

srdjan

6 years, 4 months ago (2014-07-29 22:13:24 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r38706 (presubmit successful).

Expand Messages | Collapse Messages

Issue 425083003: Use (more) xor on FP register to load it with 0.0. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages