Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Unified Diff: runtime/vm/flow_graph_compiler_ia32.cc

Issue 425083003: Use (more) xor on FP register to load it with 0.0. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/flow_graph_compiler_ia32.cc
===================================================================
--- runtime/vm/flow_graph_compiler_ia32.cc (revision 38628)
+++ runtime/vm/flow_graph_compiler_ia32.cc (working copy)
@@ -1594,6 +1594,8 @@
__ movsd(destination.fpu_reg(),
FieldAddress(EAX, Double::value_offset()));
__ popl(EAX);
+ } else if (Utils::DoublesBitEqual(constant.value(), 0.0)) {
+ __ xorps(destination.fpu_reg(), destination.fpu_reg());
} else {
__ movsd(destination.fpu_reg(), Address::Absolute(addr));
}
@@ -1605,6 +1607,8 @@
__ LoadObject(EAX, constant);
__ movsd(XMM0, FieldAddress(EAX, Double::value_offset()));
__ popl(EAX);
+ } else if (Utils::DoublesBitEqual(constant.value(), 0.0)) {
+ __ xorps(XMM0, XMM0);
} else {
__ movsd(XMM0, Address::Absolute(addr));
}

Powered by Google App Engine
This is Rietveld 408576698