Issue 387063002: Moves infrequently used debugger code in CheckInlineCachestub.

Issue 387063002: Moves infrequently used debugger code in CheckInlineCachestub. (Closed)

Created:
6 years, 5 months ago by zra

Modified:
6 years, 5 months ago

Reviewers:
Vyacheslav Egorov (Google), srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Moves infrequently used debugger code in CheckInlineCachestub. Improves unoptimized performance. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=38173

Patch Set 1 #

Total comments: 1

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+70 lines, -46 lines)			Patch
M	runtime/vm/stub_code_arm.cc	View	2 chunks	+13 lines, -8 lines	0 comments	Download
M	runtime/vm/stub_code_arm64.cc	View	2 chunks	+13 lines, -8 lines	0 comments	Download
M	runtime/vm/stub_code_ia32.cc	View	2 chunks	+13 lines, -9 lines	1 comment	Download
M	runtime/vm/stub_code_mips.cc	View	2 chunks	+18 lines, -13 lines	0 comments	Download
M	runtime/vm/stub_code_x64.cc	View	2 chunks	+13 lines, -8 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

zra

Committed patchset #1 manually as r38173 (presubmit successful).

6 years, 5 months ago (2014-07-11 21:59:29 UTC) #3

Vyacheslav Egorov (Google)

lgtm https://codereview.chromium.org/387063002/diff/1/runtime/vm/stub_code_ia32.cc File runtime/vm/stub_code_ia32.cc (right): https://codereview.chromium.org/387063002/diff/1/runtime/vm/stub_code_ia32.cc#newcode1301 runtime/vm/stub_code_ia32.cc:1301: __ movzxb(EAX, Address(EAX, Isolate::single_step_offset())); I wonder if single_step ...

6 years, 5 months ago (2014-07-11 23:31:34 UTC) #4

zra

6 years, 5 months ago (2014-07-14 16:09:53 UTC) #5

Message was sent while issue was closed.

On 2014/07/11 23:31:34, Vyacheslav Egorov (Google wrote:
> lgtm
> 
> https://codereview.chromium.org/387063002/diff/1/runtime/vm/stub_code_ia32.cc
> File runtime/vm/stub_code_ia32.cc (right):
> 
>
https://codereview.chromium.org/387063002/diff/1/runtime/vm/stub_code_ia32.cc...
> runtime/vm/stub_code_ia32.cc:1301: __ movzxb(EAX, Address(EAX,
> Isolate::single_step_offset()));
> I wonder if single_step were intptr_t would there be any visible performance
> improvement from a shorter
> 
> testl(Address(...), Immediate(1)); sequence

It seems there's also a cmpb and testb, which I could add, unless there's some
advantage to switching the field to intptr_t.

Expand Messages | Collapse Messages