Issue 384703002: Revert r38116 because of crashes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 384703002: Revert r38116 because of crashes. (Closed)

Created:
6 years, 5 months ago by Florian Schneider

Modified:
6 years, 5 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Revert r38116 because of crashes. TBR=vegorov@google.com Committed: https://code.google.com/p/dart/source/detail?r=38118

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+90 lines, -479 lines)			Patch
M	runtime/vm/assembler_ia32.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	runtime/vm/assembler_ia32.cc	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	runtime/vm/assembler_ia32_test.cc	View	1 chunk	+0 lines, -20 lines	0 comments	Download
M	runtime/vm/assembler_x64.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	runtime/vm/assembler_x64.cc	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	runtime/vm/assembler_x64_test.cc	View	1 chunk	+0 lines, -19 lines	0 comments	Download
M	runtime/vm/disassembler_ia32.cc	View	3 chunks	+4 lines, -8 lines	0 comments	Download
M	runtime/vm/flow_graph_inliner.cc	View	2 chunks	+33 lines, -15 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_type_propagator.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph_type_propagator.cc	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	5 chunks	+0 lines, -39 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	3 chunks	+1 line, -40 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View	3 chunks	+9 lines, -59 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm64.cc	View	2 chunks	+9 lines, -60 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	3 chunks	+12 lines, -61 lines	0 comments	Download
M	runtime/vm/intermediate_language_mips.cc	View	3 chunks	+10 lines, -62 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	3 chunks	+12 lines, -62 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

Committed patchset #1 manually as r38118 (presubmit successful).

6 years, 5 months ago (2014-07-10 12:50:21 UTC) #2

Message was sent while issue was closed.

LGTM

Expand Messages | Collapse Messages