Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1219)

Unified Diff: runtime/vm/disassembler_ia32.cc

Issue 384703002: Revert r38116 because of crashes. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/assembler_x64_test.cc ('k') | runtime/vm/flow_graph_inliner.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/disassembler_ia32.cc
===================================================================
--- runtime/vm/disassembler_ia32.cc (revision 38117)
+++ runtime/vm/disassembler_ia32.cc (working copy)
@@ -239,7 +239,6 @@
case 0xAF: return "imul";
case 0xA5: return "shld";
case 0xAD: return "shrd";
- case 0xA3: return "bt";
case 0xAB: return "bts";
case 0xBD: return "bsr";
case 0xB1: return "cmpxchg";
@@ -1410,17 +1409,14 @@
}
} else {
data += 2;
- if (f0byte == 0xAB ||
- f0byte == 0xA5 ||
- f0byte == 0xAD ||
- f0byte == 0xA3) {
- // shrd, shld, bts, bt
+ if (f0byte == 0xAB || f0byte == 0xA5 || f0byte == 0xAD) {
+ // shrd, shld, bts
Print(f0mnem);
int mod, regop, rm;
GetModRm(*data, &mod, &regop, &rm);
Print(" ");
data += PrintRightOperand(data);
- if (f0byte == 0xAB || f0byte == 0xA3) {
+ if (f0byte == 0xAB) {
Print(",");
PrintCPURegister(regop);
} else {
@@ -1818,7 +1814,7 @@
ASSERT(instr_len > 0); // Ensure progress.
return instr_len;
-} // NOLINT
+}
void Disassembler::DecodeInstruction(char* hex_buffer, intptr_t hex_size,
« no previous file with comments | « runtime/vm/assembler_x64_test.cc ('k') | runtime/vm/flow_graph_inliner.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698