Issue 384093002: Resolve names in combinators for PropertyInducingElements instead of PropertyAccessorElements.

Issue 384093002: Resolve names in combinators for PropertyInducingElements instead of PropertyAccessorElements. (Closed)

Created:
6 years, 5 months ago by scheglov

Modified:
6 years, 5 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Resolve names in combinators for PropertyInducingElements instead of PropertyAccessorElements. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=38199

Patch Set 1 #

Total comments: 1

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+258 lines, -174 lines)			Patch
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java	View	1 chunk	+8 lines, -1 line	1 comment	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/element/ElementFactory.java	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/resolver/ElementResolverTest.java	View	5 chunks	+23 lines, -0 lines	0 comments	Download
M	editor/util/plugins/com.google.dart.java2dart/resources/java_core.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/MainEngine.java	View	4 chunks	+0 lines, -82 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/constant.dart	View	3 chunks	+52 lines, -3 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/element.dart	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/java_core.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/resolver.dart	View	3 chunks	+112 lines, -61 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/testing/element_factory.dart	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	pkg/analyzer/pubspec.yaml	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analyzer/test/generated/resolver_test.dart	View	4 chunks	+44 lines, -0 lines	0 comments	Download
M	tests/corelib/corelib.status	View	2 chunks	+0 lines, -17 lines	0 comments	Download
M	tests/language/language_analyzer2.status	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	tests/lib/lib.status	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/384093002/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java (right): https://codereview.chromium.org/384093002/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java#newcode2538 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java:2538: element = ((PropertyAccessorElement) element).getVariable(); Perhaps a comment like: ...

6 years, 5 months ago (2014-07-13 04:20:11 UTC) #2

scheglov

6 years, 5 months ago (2014-07-14 17:11:51 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r38199 (presubmit successful).

Expand Messages | Collapse Messages