Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Unified Diff: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java

Issue 384093002: Resolve names in combinators for PropertyInducingElements instead of PropertyAccessorElements. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/element/ElementFactory.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java
diff --git a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java
index dcb4b27bab3eb8db2ca1cbdc173c533d31cc8f8e..f91d69d9d71a0c93fd4666343fce2271e6e292f8 100644
--- a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java
+++ b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java
@@ -2528,8 +2528,15 @@ public class ElementResolver extends SimpleAstVisitor<Void> {
names = ((ShowCombinator) combinator).getShownNames();
}
for (SimpleIdentifier name : names) {
- Element element = namespace.get(name.getName());
+ String nameStr = name.getName();
+ Element element = namespace.get(nameStr);
+ if (element == null) {
+ element = namespace.get(nameStr + "=");
+ }
if (element != null) {
+ if (element instanceof PropertyAccessorElement) {
+ element = ((PropertyAccessorElement) element).getVariable();
Brian Wilkerson 2014/07/13 04:20:11 Perhaps a comment like: // Ensure that the name a
+ }
name.setStaticElement(element);
}
}
« no previous file with comments | « no previous file | editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/element/ElementFactory.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698