Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: pkg/analyzer/test/generated/resolver_test.dart

Side-by-side diff isn't available for this file because of its large size.
Issue 384093002: Resolve names in combinators for PropertyInducingElements instead of PropertyAccessorElements. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: pkg/analyzer/test/generated/resolver_test.dart
diff --git a/pkg/analyzer/test/generated/resolver_test.dart b/pkg/analyzer/test/generated/resolver_test.dart
index a097820d6426b65216bcd1bd283fa1fb3996e247..1be4d21fa78049a38b278befa0c46d9c73ac9016 100644
--- a/pkg/analyzer/test/generated/resolver_test.dart
+++ b/pkg/analyzer/test/generated/resolver_test.dart
@@ -3756,6 +3756,24 @@ class CompileTimeErrorCodeTest extends ResolverTestCase {
verify([source]);
}
+ void test_symbol_constructor_badArgs() {
+ Source source = addSource(EngineTestCase.createSource([
+ "var s1 = const Symbol('3');",
+ "var s2 = const Symbol(3);",
+ "var s3 = const Symbol();",
+ "var s4 = const Symbol('x', 'y');",
+ "var s5 = const Symbol('x', foo: 'x');"]));
+ resolve(source);
+ assertErrors(source, [
+ CompileTimeErrorCode.CONST_EVAL_THROWS_EXCEPTION,
+ CompileTimeErrorCode.CONST_EVAL_THROWS_EXCEPTION,
+ StaticWarningCode.ARGUMENT_TYPE_NOT_ASSIGNABLE,
+ CompileTimeErrorCode.NOT_ENOUGH_REQUIRED_ARGUMENTS,
+ CompileTimeErrorCode.EXTRA_POSITIONAL_ARGUMENTS,
+ CompileTimeErrorCode.UNDEFINED_NAMED_PARAMETER]);
+ verify([source]);
+ }
+
void test_typeAliasCannotReferenceItself_11987() {
Source source = addSource(EngineTestCase.createSource([
"typedef void F(List<G> l);",
@@ -5482,6 +5500,10 @@ class CompileTimeErrorCodeTest extends ResolverTestCase {
final __test = new CompileTimeErrorCodeTest();
runJUnitTest(__test, __test.test_superInRedirectingConstructor_superRedirection);
});
+ _ut.test('test_symbol_constructor_badArgs', () {
+ final __test = new CompileTimeErrorCodeTest();
+ runJUnitTest(__test, __test.test_symbol_constructor_badArgs);
+ });
_ut.test('test_typeAliasCannotReferenceItself_11987', () {
final __test = new CompileTimeErrorCodeTest();
runJUnitTest(__test, __test.test_typeAliasCannotReferenceItself_11987);
@@ -6004,6 +6026,24 @@ class ElementResolverTest extends EngineTestCase {
_listener.assertNoErrors();
}
+ void test_visitImportDirective_withCombinators() {
+ ShowCombinator combinator = AstFactory.showCombinator2(["A", "B", "C"]);
+ ImportDirective directive = AstFactory.importDirective3(null, null, [combinator]);
+ LibraryElementImpl library = ElementFactory.library(_definingLibrary.context, "lib");
+ TopLevelVariableElementImpl varA = ElementFactory.topLevelVariableElement2("A");
+ TopLevelVariableElementImpl varB = ElementFactory.topLevelVariableElement2("B");
+ TopLevelVariableElementImpl varC = ElementFactory.topLevelVariableElement2("C");
+ CompilationUnitElementImpl unit = library.definingCompilationUnit as CompilationUnitElementImpl;
+ unit.accessors = <PropertyAccessorElement> [varA.getter, varA.setter, varB.getter, varC.setter];
+ unit.topLevelVariables = <TopLevelVariableElement> [varA, varB, varC];
+ directive.element = ElementFactory.importFor(library, null, []);
+ _resolveNode(directive, []);
+ JUnitTestCase.assertSame(varA, combinator.shownNames[0].staticElement);
+ JUnitTestCase.assertSame(varB, combinator.shownNames[1].staticElement);
+ JUnitTestCase.assertSame(varC, combinator.shownNames[2].staticElement);
+ _listener.assertNoErrors();
+ }
+
void test_visitIndexExpression_get() {
ClassElementImpl classA = ElementFactory.classElement2("A", []);
InterfaceType intType = _typeProvider.intType;
@@ -6551,6 +6591,10 @@ class ElementResolverTest extends EngineTestCase {
final __test = new ElementResolverTest();
runJUnitTest(__test, __test.test_visitImportDirective_noCombinators_prefix);
});
+ _ut.test('test_visitImportDirective_withCombinators', () {
+ final __test = new ElementResolverTest();
+ runJUnitTest(__test, __test.test_visitImportDirective_withCombinators);
+ });
_ut.test('test_visitIndexExpression_get', () {
final __test = new ElementResolverTest();
runJUnitTest(__test, __test.test_visitIndexExpression_get);

Powered by Google App Engine
This is Rietveld 408576698