Add breakpoints and single-stepping to Observatory.

Add breakpoints and single-stepping to Observatory.

R=johnmccutchan@google.com

Committed: https://code.google.com/p/dart/source/detail?r=38654

[Cutch, 2014-07-15 19:42:34]

no service_tests ?

https://codereview.chromium.org/381383010/diff/1/runtime/vm/debugger.cc
File runtime/vm/debugger.cc (right):

https://codereview.chromium.org/381383010/diff/1/runtime/vm/debugger.cc#newco...
runtime/vm/debugger.cc:148: jsobj.AddProperty("idNum", id());
Is there a better name than "idNum" Also, it seems redundant because the same
number is at the tail of the "id".

https://codereview.chromium.org/381383010/diff/1/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/381383010/diff/1/runtime/vm/service.cc#newcod...
runtime/vm/service.cc:1692: fprintf(stderr, "step option is %s\n", step_option);
remove before committing.

https://codereview.chromium.org/381383010/diff/20001/runtime/bin/vmservice/cl...
File runtime/bin/vmservice/client/lib/src/elements/nav_bar.dart (right):

https://codereview.chromium.org/381383010/diff/20001/runtime/bin/vmservice/cl...
runtime/bin/vmservice/client/lib/src/elements/nav_bar.dart:133:
app.removePauseEvents(event.isolate);
Should the call to removePauseEvents be folded into the step code?

[turnidge, 2014-07-15 23:37:25]

Added service_tests...

https://codereview.chromium.org/381383010/diff/1/runtime/vm/debugger.cc
File runtime/vm/debugger.cc (right):

https://codereview.chromium.org/381383010/diff/1/runtime/vm/debugger.cc#newco...
runtime/vm/debugger.cc:148: jsobj.AddProperty("idNum", id());
On 2014/07/15 19:42:34, Cutch wrote:
> Is there a better name than "idNum" Also, it seems redundant because the same
> number is at the tail of the "id".

Is redundant, but that lets us treat "id" as an opaque thing.  Have the same
situation with "id" and "mainPort" for Isolates.

How about "breakpointNumber"?

https://codereview.chromium.org/381383010/diff/1/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/381383010/diff/1/runtime/vm/service.cc#newcod...
runtime/vm/service.cc:1692: fprintf(stderr, "step option is %s\n", step_option);
On 2014/07/15 19:42:34, Cutch wrote:
> remove before committing. 

Done.

https://codereview.chromium.org/381383010/diff/20001/runtime/bin/vmservice/cl...
File runtime/bin/vmservice/client/lib/src/elements/nav_bar.dart (right):

https://codereview.chromium.org/381383010/diff/20001/runtime/bin/vmservice/cl...
runtime/bin/vmservice/client/lib/src/elements/nav_bar.dart:133:
app.removePauseEvents(event.isolate);
On 2014/07/15 19:42:34, Cutch wrote:
> Should the call to removePauseEvents be folded into the step code?

I don't think the Isolate has access to "app".

[Cutch, 2014-07-17 14:54:26]

lgtm

[turnidge, 2014-07-28 23:09:07]

Committed patchset #4 manually as r38654 (presubmit successful).

[koda, 2014-07-29 15:55:12]

https://codereview.chromium.org/381383010/diff/60001/runtime/bin/vmservice/cl...
File runtime/bin/vmservice/client/lib/src/service/object.dart (right):

https://codereview.chromium.org/381383010/diff/60001/runtime/bin/vmservice/cl...
runtime/bin/vmservice/client/lib/src/service/object.dart:418: print("GOT
$response");
Seems you left some debug printing here. But this is actually very useful, so
perhaps we could keep it in some form (e.g., enable it with a flag)?

[Cutch, 2014-07-29 17:04:35]

https://codereview.chromium.org/381383010/diff/60001/runtime/bin/vmservice/cl...
File runtime/bin/vmservice/client/lib/src/service/object.dart (right):

https://codereview.chromium.org/381383010/diff/60001/runtime/bin/vmservice/cl...
runtime/bin/vmservice/client/lib/src/service/object.dart:418: print("GOT
$response");
On 2014/07/29 15:55:12, koda wrote:
> Seems you left some debug printing here. But this is actually very useful, so
> perhaps we could keep it in some form (e.g., enable it with a flag)?

We have the logging package for this. It's easy to change the level of detail
that is printed on your machine.