Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Unified Diff: runtime/bin/vmservice/client/lib/src/elements/isolate_summary.dart

Issue 381383010: Add breakpoints and single-stepping to Observatory. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: fix bugs, gen js Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice/client/lib/src/elements/isolate_summary.dart
diff --git a/runtime/bin/vmservice/client/lib/src/elements/isolate_summary.dart b/runtime/bin/vmservice/client/lib/src/elements/isolate_summary.dart
index 28a8f1d947a4df7394433b106d35bc567c04651b..07d647a02d01506396ae0014274335558beb6013 100644
--- a/runtime/bin/vmservice/client/lib/src/elements/isolate_summary.dart
+++ b/runtime/bin/vmservice/client/lib/src/elements/isolate_summary.dart
@@ -24,22 +24,23 @@ class IsolateRunStateElement extends ObservatoryElement {
@published Isolate isolate;
Future pause(_) {
- return isolate.get("debug/pause").then((result) {
- // TODO(turnidge): Instead of asserting here, handle errors
- // properly.
- assert(result.serviceType == 'Success');
- return isolate.reload();
- });
+ return isolate.pause();
}
-
Future resume(_) {
- return isolate.get("debug/resume").then((result) {
- // TODO(turnidge): Instead of asserting here, handle errors
- // properly.
- assert(result.serviceType == 'Success');
- app.removePauseEvents(isolate);
- return isolate.reload();
- });
+ app.removePauseEvents(isolate);
+ return isolate.resume();
+ }
+ Future stepInto(_) {
+ app.removePauseEvents(isolate);
+ return isolate.stepInto();
+ }
+ Future stepOver(_) {
+ app.removePauseEvents(isolate);
+ return isolate.stepOver();
+ }
+ Future stepOut(_) {
+ app.removePauseEvents(isolate);
+ return isolate.stepOut();
}
}

Powered by Google App Engine
This is Rietveld 408576698