Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Unified Diff: runtime/bin/vmservice/client/lib/src/app/application.dart

Issue 381383010: Add breakpoints and single-stepping to Observatory. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: fix bugs, gen js Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice/client/lib/src/app/application.dart
diff --git a/runtime/bin/vmservice/client/lib/src/app/application.dart b/runtime/bin/vmservice/client/lib/src/app/application.dart
index 620d82c2a8c1e34af0884e1128d90a457a10a5d1..567422caf2968a544e7c3b31da0ef17d7961c1c8 100644
--- a/runtime/bin/vmservice/client/lib/src/app/application.dart
+++ b/runtime/bin/vmservice/client/lib/src/app/application.dart
@@ -20,6 +20,7 @@ class ObservatoryApplication extends Observable {
}
if (_vm != null) {
// Disconnect from current VM.
+ notifications.clear();
_vm.disconnect();
}
if (vm != null) {
@@ -27,6 +28,7 @@ class ObservatoryApplication extends Observable {
vm.onConnect.then(_vmConnected);
vm.onDisconnect.then(_vmDisconnected);
vm.errors.stream.listen(_onError);
+ vm.events.stream.listen(_onEvent);
vm.exceptions.stream.listen(_onException);
}
_vm = vm;
@@ -59,7 +61,7 @@ class ObservatoryApplication extends Observable {
});
}
- void _handleEvent(ServiceEvent event) {
+ void _onEvent(ServiceEvent event) {
switch(event.eventType) {
case 'IsolateCreated':
// vm.reload();
@@ -74,7 +76,7 @@ class ObservatoryApplication extends Observable {
break;
case 'BreakpointResolved':
- // Do nothing.
+ event.isolate.reloadBreakpoints();
break;
case 'BreakpointReached':

Powered by Google App Engine
This is Rietveld 408576698