Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 376053003: Do not notify debugger on stack overflow (Closed)

Created:
6 years, 5 months ago by hausner
Modified:
6 years, 5 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org, devoncarew, Jacob
Visibility:
Public.

Description

Do not notify debugger on stack overflow Don’t call back to the debugger on out of memory and stack overflow exceptions. The debugger can’t do anything meaningful on the VM when the stack is full. This should eliminate crashes we see in Dartium devtools. This means we can no longer intercept stack overflows with the debugger. In a later change, I plan to add uncomment the code that notifies the debugger of the exception after the stack in unwound. Before this notification gets uncommented, we need to make sure that debuggers can handle notifications with an empty stack. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=38086

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M runtime/vm/exceptions.cc View 1 chunk +7 lines, -1 line 0 comments Download
M runtime/vm/isolate.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
hausner
6 years, 5 months ago (2014-07-09 00:19:58 UTC) #1
siva
lgtm
6 years, 5 months ago (2014-07-09 00:35:36 UTC) #2
hausner
6 years, 5 months ago (2014-07-09 16:09:18 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r38086 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698