Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Unified Diff: runtime/vm/isolate.cc

Issue 376053003: Do not notify debugger on stack overflow (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/exceptions.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/isolate.cc
===================================================================
--- runtime/vm/isolate.cc (revision 38068)
+++ runtime/vm/isolate.cc (working copy)
@@ -345,6 +345,13 @@
// Invoke the isolate's uncaught exception handler, if it exists.
const UnhandledException& error = UnhandledException::Cast(result);
RawInstance* exception = error.exception();
+ if ((exception == I->object_store()->out_of_memory()) ||
+ (exception == I->object_store()->stack_overflow())) {
+ // We didn't notify the debugger when the stack was full. Do it now.
+ // TODO(hausner): uncomment the debugger notification once debuggers
+ // can deal with exceptions thrown on an empty stack.
+ // I->debugger()->SignalExceptionThrown(Instance::Handle(exception));
+ }
if ((exception != I->object_store()->out_of_memory()) &&
(exception != I->object_store()->stack_overflow())) {
if (UnhandledExceptionCallbackHandler(message, error)) {
« no previous file with comments | « runtime/vm/exceptions.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698