Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: runtime/vm/exceptions.cc

Issue 376053003: Do not notify debugger on stack overflow (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/isolate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/exceptions.cc
===================================================================
--- runtime/vm/exceptions.cc (revision 38068)
+++ runtime/vm/exceptions.cc (working copy)
@@ -585,7 +585,13 @@
void Exceptions::Throw(Isolate* isolate, const Instance& exception) {
- isolate->debugger()->SignalExceptionThrown(exception);
+ // Do not notify debugger on stack overflow and out of memory exceptions.
+ // The VM would crash when the debugger calls back into the VM to
+ // get values of variables.
+ if (exception.raw() != isolate->object_store()->out_of_memory() &&
+ exception.raw() != isolate->object_store()->stack_overflow()) {
+ isolate->debugger()->SignalExceptionThrown(exception);
+ }
// Null object is a valid exception object.
ThrowExceptionHelper(isolate, exception, Instance::Handle(isolate), false);
}
« no previous file with comments | « no previous file | runtime/vm/isolate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698