Fix debugging module(replace int with intptr_t) so it works on Windows x64.

Fix debugging module(replace int with intptr_t) so it works on Windows x64.

R=iposva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=37996

[Ivan Posva, 2014-07-03 05:33:41]

LGTM with the other platform specific files fixed.

A quick glance at the files handling debugger connections showed that there are
more potential issues in this area. Filed http://dartbug.com/19812

-Ivan

https://codereview.chromium.org/369023002/diff/1/runtime/bin/dbg_connection_w...
File runtime/bin/dbg_connection_win.cc (right):

https://codereview.chromium.org/369023002/diff/1/runtime/bin/dbg_connection_w...
runtime/bin/dbg_connection_win.cc:25: reinterpret_cast<intptr_t>(socket));
The other platform dependent files suffer similar issues with int and intptr_t
confusion for the file descriptors. Please update them as well.

[aam-me, 2014-07-03 11:19:30]

Thank you Ivan!

Please take another look to confirm changes to other platform specific files.

[Ivan Posva, 2014-07-03 12:50:19]

LGTM once the comment is addressed.

Thanks,
-Ivan

https://codereview.chromium.org/369023002/diff/60001/runtime/bin/dbg_connecti...
File runtime/bin/dbg_connection.cc (right):

https://codereview.chromium.org/369023002/diff/60001/runtime/bin/dbg_connecti...
runtime/bin/dbg_connection.cc:211: Log::Print("[<<<] Receiving message from
debug fd %ld:\n%.*s%s\n",
We have a specific macro that is used to format an intptr_t: Pd
See for example deb_message.cc line 253. Hint: The spaces between the " and the
macro Pd are mandatory.

https://codereview.chromium.org/369023002/diff/60001/runtime/bin/dbg_connecti...
runtime/bin/dbg_connection.cc:386: Log::Print("[>>>] Sending message to debug fd
%ld:\n%.*s%s\n",
ditto

[aam-me, 2014-07-03 16:56:41]

Thanks Ivan.

Should be all set now.

[aam-me, 2014-07-03 16:57:28]

Will commit later tonight if that is okay.

https://codereview.chromium.org/369023002/diff/60001/runtime/bin/dbg_connecti...
File runtime/bin/dbg_connection.cc (right):

https://codereview.chromium.org/369023002/diff/60001/runtime/bin/dbg_connecti...
runtime/bin/dbg_connection.cc:211: Log::Print("[<<<] Receiving message from
debug fd %ld:\n%.*s%s\n",
On 2014/07/03 12:50:19, Ivan Posva wrote:
> We have a specific macro that is used to format an intptr_t: Pd
> See for example deb_message.cc line 253. Hint: The spaces between the " and
the
> macro Pd are mandatory.

Done.

https://codereview.chromium.org/369023002/diff/60001/runtime/bin/dbg_connecti...
runtime/bin/dbg_connection.cc:386: Log::Print("[>>>] Sending message to debug fd
%ld:\n%.*s%s\n",
On 2014/07/03 12:50:19, Ivan Posva wrote:
> ditto

Done.

[aam-me, 2014-07-03 23:26:05]

Committed patchset #5 manually as r37996 (presubmit successful).