Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Unified Diff: runtime/bin/dbg_message.h

Issue 369023002: Fix debugging module(replace int with intptr_t) so it works on Windows x64. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/dbg_connection_win.cc ('k') | runtime/bin/dbg_message.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/dbg_message.h
===================================================================
--- runtime/bin/dbg_message.h (revision 37971)
+++ runtime/bin/dbg_message.h (working copy)
@@ -63,7 +63,7 @@
class DbgMessage {
public:
DbgMessage(int32_t cmd_idx, const char* start,
- const char* end, int debug_fd)
+ const char* end, intptr_t debug_fd)
: next_(NULL), cmd_idx_(cmd_idx),
buffer_(NULL), buffer_len_(end - start),
debug_fd_(debug_fd) {
@@ -81,7 +81,7 @@
void set_next(DbgMessage* next) { next_ = next; }
char* buffer() const { return buffer_; }
int32_t buffer_len() const { return buffer_len_; }
- int debug_fd() const { return debug_fd_; }
+ intptr_t debug_fd() const { return debug_fd_; }
// Handle debugger command message.
// Returns true if the execution needs to resume after this message is
@@ -121,7 +121,7 @@
int32_t cmd_idx_; // Isolate specific debugger command index.
char* buffer_; // Debugger command message.
int32_t buffer_len_; // Length of the debugger command message.
- int debug_fd_; // Debugger connection on which replies are to be sent.
+ intptr_t debug_fd_; // Debugger connection on which replies are to be sent.
DISALLOW_IMPLICIT_CONSTRUCTORS(DbgMessage);
};
@@ -160,7 +160,7 @@
void AddMessage(int32_t cmd_idx,
const char* start,
const char* end,
- int debug_fd);
+ intptr_t debug_fd);
// Notify an isolate of a pending vmservice message.
void Notify();
@@ -232,7 +232,7 @@
int32_t cmd_idx,
const char* start,
const char* end,
- int debug_fd);
+ intptr_t debug_fd);
// Notify an isolate of a pending vmservice message.
static void NotifyIsolate(Dart_Isolate isolate);
« no previous file with comments | « runtime/bin/dbg_connection_win.cc ('k') | runtime/bin/dbg_message.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698