Make retained size human-readable.

Make retained size human-readable.

BUG=dart:19444
R=johnmccutchan@google.com

Committed: https://code.google.com/p/dart/source/detail?r=37614

[Cutch, 2014-06-23 16:16:39]

LGTM after addressing @published comment.

Also, an optional suggestion.

https://codereview.chromium.org/350573002/diff/1/runtime/bin/vmservice/client...
File runtime/bin/vmservice/client/lib/src/elements/class_view.dart (right):

https://codereview.chromium.org/350573002/diff/1/runtime/bin/vmservice/client...
runtime/bin/vmservice/client/lib/src/elements/class_view.dart:15: @published int
retainedBytes;
Does this need to be published? I think observable is sufficient.

In case you didn't already know this:

@reflectable (no longer necessary but keeps a symbol around for mirrors).
@observable - (implies @reflectable) a property which we will reference in {{ }}
expressions that we want to auto updated.
@published - (implies @observable) a property settable from html, e.g.:
<class-view retainedBytes="77"></class-view>

https://codereview.chromium.org/350573002/diff/1/runtime/bin/vmservice/client...
runtime/bin/vmservice/client/lib/src/elements/class_view.dart:25: return
cls.isolate.get(cls.id + "/retained")
Maybe add a .get to Class:

cls.get('retained');

https://codereview.chromium.org/350573002/diff/1/runtime/bin/vmservice/client...
File runtime/bin/vmservice/client/lib/src/elements/instance_view.dart (right):

https://codereview.chromium.org/350573002/diff/1/runtime/bin/vmservice/client...
runtime/bin/vmservice/client/lib/src/elements/instance_view.dart:16: @published
int retainedBytes = null;
@observable ?

[koda, 2014-06-23 18:44:09]

https://codereview.chromium.org/350573002/diff/1/runtime/bin/vmservice/client...
File runtime/bin/vmservice/client/lib/src/elements/class_view.dart (right):

https://codereview.chromium.org/350573002/diff/1/runtime/bin/vmservice/client...
runtime/bin/vmservice/client/lib/src/elements/class_view.dart:15: @published int
retainedBytes;
On 2014/06/23 16:16:39, Cutch wrote:
> Does this need to be published? I think observable is sufficient.
> 
> In case you didn't already know this:
> 
> @reflectable (no longer necessary but keeps a symbol around for mirrors).
> @observable - (implies @reflectable) a property which we will reference in {{
}}
> expressions that we want to auto updated.
> @published - (implies @observable) a property settable from html, e.g.:
> <class-view retainedBytes="77"></class-view>

True. Thanks for clarifying!

https://codereview.chromium.org/350573002/diff/1/runtime/bin/vmservice/client...
runtime/bin/vmservice/client/lib/src/elements/class_view.dart:25: return
cls.isolate.get(cls.id + "/retained")
On 2014/06/23 16:16:39, Cutch wrote:
> Maybe add a .get to Class:
> 
> cls.get('retained');

Done.

https://codereview.chromium.org/350573002/diff/1/runtime/bin/vmservice/client...
File runtime/bin/vmservice/client/lib/src/elements/instance_view.dart (right):

https://codereview.chromium.org/350573002/diff/1/runtime/bin/vmservice/client...
runtime/bin/vmservice/client/lib/src/elements/instance_view.dart:16: @published
int retainedBytes = null;
On 2014/06/23 16:16:39, Cutch wrote:
> @observable ?

Done.

[koda, 2014-06-23 19:47:14]

Committed patchset #3 manually as r37614 (presubmit successful).