runtime/bin/vmservice/client/lib/src/elements/instance_view.dart - Issue 350573002: Make retained size human-readable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice/client/lib/src/elements/instance_view.dart

Issue 350573002: Make retained size human-readable. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/bin/vmservice/client/lib/src/elements/instance_view.dart

===================================================================

--- runtime/bin/vmservice/client/lib/src/elements/instance_view.dart (revision 37613)

+++ runtime/bin/vmservice/client/lib/src/elements/instance_view.dart (working copy)

@@ -13,6 +13,7 @@

class InstanceViewElement extends ObservatoryElement {

@published ServiceMap instance;

@published ServiceMap path;

+ @observable int retainedBytes = null;

InstanceViewElement.created() : super.created();

@@ -23,7 +24,10 @@

// TODO(koda): Add no-arg "calculate-link" instead of reusing "eval-link".

Future<ServiceObject> retainedSize(var dummy) {

- return instance.isolate.get(instance.id + "/retained");

+ return instance.isolate.get(instance.id + "/retained")

+ .then((ServiceMap obj) {

+ retainedBytes = int.parse(obj['valueAsString']);

+ });

}

Future<ServiceObject> retainingPath(var arg) {