Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Side by Side Diff: runtime/bin/vmservice/client/lib/src/elements/class_view.dart

Issue 350573002: Make retained size human-readable. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library class_view_element; 5 library class_view_element;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 import 'observatory_element.dart'; 8 import 'observatory_element.dart';
9 import 'package:observatory/service.dart'; 9 import 'package:observatory/service.dart';
10 import 'package:polymer/polymer.dart'; 10 import 'package:polymer/polymer.dart';
11 11
12 @CustomTag('class-view') 12 @CustomTag('class-view')
13 class ClassViewElement extends ObservatoryElement { 13 class ClassViewElement extends ObservatoryElement {
14 @published Class cls; 14 @published Class cls;
15 @published int retainedBytes;
Cutch 2014/06/23 16:16:39 Does this need to be published? I think observable
koda 2014/06/23 18:44:09 True. Thanks for clarifying!
15 ClassViewElement.created() : super.created(); 16 ClassViewElement.created() : super.created();
16 17
17 Future<ServiceObject> eval(String text) { 18 Future<ServiceObject> eval(String text) {
18 return cls.isolate.get( 19 return cls.isolate.get(
19 cls.id + "/eval?expr=${Uri.encodeComponent(text)}"); 20 cls.id + "/eval?expr=${Uri.encodeComponent(text)}");
20 } 21 }
21 22
22 // TODO(koda): Add no-arg "calculate-link" instead of reusing "eval-link". 23 // TODO(koda): Add no-arg "calculate-link" instead of reusing "eval-link".
23 Future<ServiceObject> retainedSize(String dummy) { 24 Future<ServiceObject> retainedSize(var dummy) {
24 return cls.isolate.get(cls.id + "/retained"); 25 return cls.isolate.get(cls.id + "/retained")
Cutch 2014/06/23 16:16:39 Maybe add a .get to Class: cls.get('retained');
koda 2014/06/23 18:44:09 Done.
26 .then((ServiceMap obj) {
27 retainedBytes = int.parse(obj['valueAsString']);
28 });
25 } 29 }
26 30
27 void refresh(var done) { 31 void refresh(var done) {
28 cls.reload().whenComplete(done); 32 cls.reload().whenComplete(done);
29 } 33 }
30 } 34 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698