Issue 345533004: Use "self" instead of globalThis.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 345533004: Use "self" instead of globalThis. (Closed)

Created:
6 years, 6 months ago by ahe

Modified:
6 years, 6 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org, floitsch

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Use "self" instead of globalThis. Main benefits: * Simpler code. * Smaller generated code (no use of lazy statics). * One step closer to "use strict" as Primitives.computeGlobalThis() wouldn't work in strict mode. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=37483

Patch Set 1 #

Patch Set 2 : Merged with r37482. #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -42 lines)			Patch
M	dart/sdk/lib/_internal/lib/async_patch.dart	View		3 chunks	+3 lines, -5 lines	0 comments	Download
M	dart/sdk/lib/_internal/lib/isolate_helper.dart	View		8 chunks	+13 lines, -19 lines	0 comments	Download
M	dart/sdk/lib/_internal/lib/js_helper.dart	View	1	2 chunks	+1 line, -3 lines	0 comments	Download
M	dart/sdk/lib/_internal/lib/preambles/d8.js	View		2 chunks	+13 lines, -14 lines	0 comments	Download
M	dart/sdk/lib/_internal/lib/preambles/jsshell.js	View		1 chunk	+9 lines, -0 lines	0 comments	Download
M	dart/sdk/lib/js/dart2js/js_dart2js.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ahe

After explaining the purpose of "self" once again, I decided to write a wiki page ...

6 years, 6 months ago (2014-06-18 12:28:04 UTC) #1

ahe

Thank you, Johnni! FYI: Added another benefit to the description: * One step closer to ...

6 years, 6 months ago (2014-06-18 13:18:47 UTC) #3

ahe

6 years, 6 months ago (2014-06-19 09:46:43 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r37483 (presubmit successful).

Expand Messages | Collapse Messages